From: Ivo van Doorn <ivdoorn@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: netdev@vger.kernel.org, rt2x00-devel@lfcorreia.dyndns.org
Subject: Re: [PATCH 20/32] rt2x00: byte ordering correctness
Date: Fri, 28 Apr 2006 14:59:23 +0200 [thread overview]
Message-ID: <200604281459.24186.IvDoorn@gmail.com> (raw)
In-Reply-To: <20060427221321.GB22135@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Friday 28 April 2006 00:13, Christoph Hellwig wrote:
> On Fri, Apr 28, 2006 at 12:03:12AM +0200, Ivo van Doorn wrote:
> > From: Ivo van Doorn <IvDoorn@gmail.com>
> >
> > Fix various little/big endian conversions.
> > rt2500pci should use cpu_to_le32 and rt2500usb should not.
>
> While you're at it can you add __be* annotations to the hardware
> datastructures so the endianess handling can be verified using sparse?
I am not sure if that would be a wise idea,
there is no byte ordering done in rt2500usb except for the EEPROM
contents which is little endian.
So when the module is used on a normal x86 platform, there won't be
any big endian structures or fields.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-04-28 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 22:03 [PATCH 20/32] rt2x00: byte ordering correctness Ivo van Doorn
2006-04-27 22:13 ` Christoph Hellwig
2006-04-28 12:59 ` Ivo van Doorn [this message]
2006-04-28 13:14 ` Christoph Hellwig
2006-04-28 13:31 ` Ivo van Doorn
2006-04-28 13:42 ` Michael Buesch
2006-04-28 13:45 ` Ivo van Doorn
2006-04-28 13:46 ` Christoph Hellwig
2006-04-28 13:56 ` Michael Buesch
2006-04-28 15:01 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604281459.24186.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=hch@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rt2x00-devel@lfcorreia.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.