From: Pavel Machek <pavel@ucw.cz>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] don't use flush_tlb_all in suspend time
Date: Sun, 30 Apr 2006 06:45:05 +0000 [thread overview]
Message-ID: <20060430064505.GA5091@ucw.cz> (raw)
In-Reply-To: <1146367462.21486.10.camel@sli10-desk.sh.intel.com>
Hi!
> flush_tlb_all uses on_each_cpu, which will disable/enable interrupt.
> In suspend/resume time, this will make interrupt wrongly enabled.
> diff -puN arch/i386/mm/init.c~flush_tlb_all_check arch/i386/mm/init.c
> --- linux-2.6.17-rc3/arch/i386/mm/init.c~flush_tlb_all_check 2006-04-29 08:47:05.000000000 +0800
> +++ linux-2.6.17-rc3-root/arch/i386/mm/init.c 2006-04-29 08:48:15.000000000 +0800
> @@ -420,7 +420,10 @@ void zap_low_mappings (void)
> #else
> set_pgd(swapper_pg_dir+i, __pgd(0));
> #endif
> - flush_tlb_all();
> + if (cpus_weight(cpu_online_map) == 1)
> + local_flush_tlb();
> + else
> + flush_tlb_all();
> }
>
Either it is okay to enable interrupts here -> unneccessary and ugly
test, or it is not, and then we are broken in SMP case.
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2006-04-30 6:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-30 3:24 [PATCH] don't use flush_tlb_all in suspend time Shaohua Li
2006-04-30 6:45 ` Pavel Machek [this message]
2006-04-30 6:46 ` Shaohua Li
2006-04-30 6:57 ` Andrew Morton
2006-04-30 7:19 ` Shaohua Li
2006-04-30 12:04 ` Pavel Machek
2006-05-08 2:27 ` Shaohua Li
2006-05-18 3:29 ` Shaohua Li
2006-05-18 8:31 ` Pavel Machek
2006-05-18 8:38 ` Shaohua Li
2006-05-18 8:46 ` Pavel Machek
2006-05-19 1:15 ` Shaohua Li
2006-05-20 15:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060430064505.GA5091@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.