From: Greg KH <greg@kroah.com>
To: Razvan Gavril <razvan.g@plutohome.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
Date: Tue, 2 May 2006 13:05:32 -0700 [thread overview]
Message-ID: <20060502200532.GA8172@kroah.com> (raw)
In-Reply-To: <44572749.6090103@plutohome.com>
On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
Care to diff this against 2.6.17-rc3? Lots of ftdi new device ids have
been added there.
You also forgot to add a "Signed-off-by:" line :(
> diff -Nur linux-2.6.16.12/drivers/usb/serial/ftdi_sio.c linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.c
> --- linux-2.6.16.12/drivers/usb/serial/ftdi_sio.c 2006-05-01 15:14:26.000000000 -0400
> +++ linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.c 2006-05-02 05:12:10.000000000 -0400
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -Nur linux-2.6.16.12/drivers/usb/serial/ftdi_sio.h linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h
> --- linux-2.6.16.12/drivers/usb/serial/ftdi_sio.h 2006-05-01 15:14:26.000000000 -0400
> +++ linux-2.6.16.12-pluto-1/drivers/usb/serial/ftdi_sio.h 2006-05-02 05:13:00.000000000 -0400
> @@ -380,6 +380,9 @@
> /* Pyramid Computer GmbH */
> #define FTDI_PYRAMID_PID 0xE6C8 /* Pyramid Appliance Display */
>
> +/* ACT Solutions HomePro ZWave interface (http://www.act-solutions.com/HomePro.htm) */
> +#define FTDI_ACTZWAVE_PID 0xF2D0
Please use a tab here.
thanks,
greg k-h
next prev parent reply other threads:[~2006-05-02 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 9:32 [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface Razvan Gavril
2006-05-02 20:05 ` Greg KH [this message]
2006-05-03 12:18 ` Razvan Gavril
2006-05-03 17:43 ` Greg KH
2006-05-04 8:35 ` Razvan Gavril
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060502200532.GA8172@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=razvan.g@plutohome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.