All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Razvan Gavril <razvan.g@plutohome.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface
Date: Wed, 3 May 2006 10:43:49 -0700	[thread overview]
Message-ID: <20060503174349.GA3098@kroah.com> (raw)
In-Reply-To: <44589FB0.6090909@plutohome.com>

On Wed, May 03, 2006 at 03:18:56PM +0300, Razvan Gavril wrote:
> Greg KH wrote:
> >On Tue, May 02, 2006 at 12:32:57PM +0300, Razvan Gavril wrote:
> >
> >Care to diff this against 2.6.17-rc3?  Lots of ftdi new device ids have
> >been added there.
> >
> >You also forgot to add a "Signed-off-by:" line :(
> 
> Signed-Off By: Razvan Gavril <razvan.g@plutohome.com>

Care to add a good text for what the patch does?

> ---
> 
> diff -Nur linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c 
> linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c
> --- linux-2.6.17-rc3-orig/drivers/usb/serial/ftdi_sio.c 2006-05-03 
> 15:12:01.000000000 +0300

The patch is line wrapped :(

> +++ linux-2.6.17-rc3/drivers/usb/serial/ftdi_sio.c      2006-05-03 
> 15:04:39.000000000 +0300
> @@ -307,6 +307,7 @@
> 
> 
> static struct usb_device_id id_table_combined [] = {
> +       { USB_DEVICE(FTDI_VID, FTDI_ACTZWAVE_PID) },
>        { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
>        { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
>        { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },

And the tabs were stripped by your email client :(

Care to try again?

thanks,

greg k-h

  reply	other threads:[~2006-05-03 17:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02  9:32 [PATCH] ftdi_sio: ACT Solutions HomePro ZWave interface Razvan Gavril
2006-05-02 20:05 ` Greg KH
2006-05-03 12:18   ` Razvan Gavril
2006-05-03 17:43     ` Greg KH [this message]
2006-05-04  8:35       ` Razvan Gavril

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060503174349.GA3098@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=razvan.g@plutohome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.