From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750859AbWECUkL (ORCPT ); Wed, 3 May 2006 16:40:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751012AbWECUkK (ORCPT ); Wed, 3 May 2006 16:40:10 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:10436 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S1750859AbWECUkJ (ORCPT ); Wed, 3 May 2006 16:40:09 -0400 Date: Wed, 3 May 2006 22:45:04 +0200 From: Ingo Molnar To: Daniel Walker Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH -rt] scheduling while atomic in fs/file.c Message-ID: <20060503204504.GA15965@elte.hu> References: <200604221503.k3MF3Ws8021873@dwalker1.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604221503.k3MF3Ws8021873@dwalker1.mvista.com> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: -2.8 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.8 required=5.9 tests=ALL_TRUSTED,AWL autolearn=no SpamAssassin version=3.0.3 -2.8 ALL_TRUSTED Did not pass through any untrusted hosts 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Walker wrote: > - fddef = &get_cpu_var(fdtable_defer_list); > + fddef = &__get_cpu_var(fdtable_defer_list); ok, the bug you found is real - but i dont like the fix: now we will be using smp_processor_id() in preemptible code, which will trip up under DEBUG_PREEMPT. Since in this particular case any CPU is fine, per_cpu(...,raw_smp_processor_id()) ought to do the trick. Mind to update the patch? Ingo