All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Paul Mundt <paul.mundt@nokia.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 2.6.17-rc3-omap] omap_uwire byteswap bugfix
Date: Thu, 4 May 2006 08:18:43 -0700	[thread overview]
Message-ID: <200605040818.44126.david-b@pacbell.net> (raw)
In-Reply-To: <20060504145344.GA21933@nokia.com>

On Thursday 04 May 2006 7:53 am, Paul Mundt wrote:

> > +	if (spi->mode & SPI_LSB_FIRST) {
> > +		pr_debug("%s: lsb first?\n", spi->dev.bus_id);
> > +		status = -EINVAL;
> > +		goto done;
> > +	}
> > +
> >  	/* mode 0..3, clock inverted separately;
> >  	 * standard nCS signaling;
> >  	 * don't treat DI=high as "not ready"
> 
> This breaks the build, SPI_LSB_FIRST isn't defined anywhere..
> ...
> Looks like this is missing..
> 
> 	http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/spi-devices-can-require-lsb-first-encodings.patch
> 
> which isn't in Linus's tree either yet however.

Whoops, yes.  My bad, sorry; it was in _my_ tree and I overlooked how it got there.
I thought maybe Juha had merged it.

Simplest fix would be to merge that patch from Greg's tree.

- Dave

  reply	other threads:[~2006-05-04 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-03  5:15 [PATCH 2.6.17-rc3-omap] omap_uwire byteswap bugfix David Brownell
2006-05-04 14:53 ` Paul Mundt
2006-05-04 15:18   ` David Brownell [this message]
2006-05-04 17:07     ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200605040818.44126.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=paul.mundt@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.