From: Kevin Corry <kevcorry@us.ibm.com>
To: dm-devel@redhat.com
Cc: Eric Sandeen <sandeen@sgi.com>, m9230 <m9230@cn.ee.ccu.edu.tw>
Subject: Re: [PATCH] dm.c
Date: Fri, 5 May 2006 08:56:43 -0500 [thread overview]
Message-ID: <200605050856.44400.kevcorry@us.ibm.com> (raw)
In-Reply-To: <200605050845.30546.kevcorry@us.ibm.com>
On Fri May 5 2006 8:45 am, Kevin Corry wrote:
> I haven't seen an actual patch yet for this bug, so here's one with the
> suggested fix (against 2.4.31 + device-mapper-1.02.05).
And just in case it's easier for the DM guys, here's the same fix as a patch
against linux-2.4.28-pre4-devmapper-ioctl.patch from device-mapper-1.02.05.
--
Kevin Corry
kevcorry@us.ibm.com
http://www.ibm.com/linux/
http://evms.sourceforge.net/
In dm_blk_ioctl(), change 'size' to a sector_t so we can correctly return
the size of devices between 1 and 2 TB.
Fix suggested by Eric Sandeen <sandeen@sgi.com>
http://oss.sgi.com/bugzilla/show_bug.cgi?id=646
Signed-Off-By: Kevin Corry <kevcorry@us.ibm.com>
Index: device-mapper.1.02.05/patches/linux-2.4.28-pre4-devmapper-ioctl.patch
===================================================================
--- device-mapper.1.02.05.orig/patches/linux-2.4.28-pre4-devmapper-ioctl.patch
+++ device-mapper.1.02.05/patches/linux-2.4.28-pre4-devmapper-ioctl.patch
@@ -7823,7 +7823,7 @@
+ unsigned int command, unsigned long a)
+{
+ kdev_t dev = inode->i_rdev;
-+ long size;
++ sector_t size;
+
+ switch (command) {
+ case BLKROSET:
@@ -7843,7 +7843,7 @@
+
+ case BLKGETSIZE:
+ size = volume_size(dev);
-+ if (copy_to_user((void *) a, &size, sizeof(long)))
++ if (put_user((unsigned long) size, (unsigned long *) a))
+ return -EFAULT;
+ break;
+
next prev parent reply other threads:[~2006-05-05 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060504160048.CA34173C68@hormel.redhat.com>
2006-05-05 7:35 ` [PATCH] dm.c m9230
2006-05-05 13:45 ` Kevin Corry
2006-05-05 13:56 ` Kevin Corry [this message]
2006-05-05 14:09 ` Eric Sandeen
2006-05-04 2:51 m9230
-- strict thread matches above, loose matches on Subject: below --
2006-05-04 1:51 m9230
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605050856.44400.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=dm-devel@redhat.com \
--cc=m9230@cn.ee.ccu.edu.tw \
--cc=sandeen@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.