Re: [uml-devel] do_uml_initcalls

[Jeff Dike <jdike@addtoit.com>]

On Sun, May 07, 2006 at 02:54:12PM +0200, user-mode-linux-devel-admin@lists.sourceforge.net wrote:
> First, there's a ';' at the end of line 6 : typo error I guess.

Yup, nice spotting.

> But my point is : this function is unreadable !

It could hardly get any simpler.

> It does simply call all the functions in the ".initcall"
> section.
> 
> Wouldn't it be better to call all the functions explicitely ?

No, adding an initcall now is a matter of writing it and declaring it
as an initcall, which adds one contiguous piece of code to one file.
Adding an explicit call means 
	writing the function
	declaring it in a header so that do_uml_initcalls will see it
	including that header in the file that implements the function
to ensure that the implementation and declaration are the same
	adding the call to do_uml_initcalls

Aside from the extra code that requires, the calls and the
declarations would turn into a hot spot that a lot of patches change,
and hot spots are a pain when it comes to reordering patches.

> Btw, what is the difference between the initcall and init sections ?

init sections are code which are executed only during initialization
and which can be thrown out once the kernel is booted.  initcall makes
the function be automatically called, init just makes it be thrown out
- you have to arrange to call it yourself.

> Because I was thinking of another problem : the modules. If some modules
> are compiled and that the init_modules functions are put in the initcall
> section, then all the modules will be loaded.

I don't think so.  The init functions can only be called if they are
in the kernel's initcall section, and then they aren't modules any
more.

				Jeff


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel