All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Oeser <netdev@axxeo.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Miika Komu <miika@iki.fi>,
	Diego Beltrami <Diego.Beltrami@hiit.fi>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [RFC 1/3] [IPSEC] xfrm: Undo afinfo lock proliferation
Date: Mon, 8 May 2006 15:58:10 +0200	[thread overview]
Message-ID: <200605081558.10528.netdev@axxeo.de> (raw)
In-Reply-To: <20060508134729.GA13089@gondor.apana.org.au>

Hi Herbert,

Herbert Xu schrieb:
> It's just moving an existing line down if you look further up in
> the patch.  Of couse I would have nothing against a patch that
> replaced 256 with IPPROTO_MAX or something.

Ahh, that's the actual meaning here... 

> However, I prefer to not mix clean-ups with substantive changes so
> if you have the time please post a separate patch for this.  Otherwise
> I'll do a patch when I resubmit this.

Would be nice to include such a patch in this patchset, since you seem
to be able to decipher that magic value :-)


Thanks & Regards

Ingo Oeser

  reply	other threads:[~2006-05-08 13:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1145343829.44448f556684c@webmail.hiit.fi>
     [not found] ` <20060418080340.GA2206@gondor.apana.org.au>
     [not found]   ` <Pine.SOL.4.64.0604181512460.26361@kekkonen.cs.hut.fi>
     [not found]     ` <20060419110209.GA15584@gondor.apana.org.au>
     [not found]       ` <Pine.SOL.4.64.0604191529100.11141@kekkonen.cs.hut.fi>
2006-05-06 11:20         ` [RFC 0/3] [IPSEC]: Add xfrm_mode support Herbert Xu
2006-05-06 11:21           ` [RFC 1/3] [IPSEC] xfrm: Undo afinfo lock proliferation Herbert Xu
     [not found]             ` <200605081522.14524.netdev@axxeo.de>
2006-05-08 13:47               ` Herbert Xu
2006-05-08 13:58                 ` Ingo Oeser [this message]
2006-05-06 11:21           ` [RFC 2/3] [IPSEC] xfrm: Abstract out encapsulation modes Herbert Xu
2006-05-06 11:24           ` [RFC 3/3] [IPSEC]: Abstract out transport mode input code Herbert Xu
2006-05-10 20:54           ` [RFC 0/3] [IPSEC]: Add xfrm_mode support David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200605081558.10528.netdev@axxeo.de \
    --to=netdev@axxeo.de \
    --cc=Diego.Beltrami@hiit.fi \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=miika@iki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.