Re: [PATCH 8/8] aic94xx: use bitops for testing, setting and clearing bits

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

Am Dienstag, 9. Mai 2006 23:42 schrieben Sie:
>Use bitops for testing, setting and clearing bits
>
>Signed-off-by: Alexis Bruemmer <alexisb@us.ibm.com>
>Signed-off-by: Mike Anderson <andmike@us.ibm.com>
>
>---
> drivers/scsi/sas/sas_internal.h |   16 +++++++++-------
> include/scsi/sas/sas_class.h    |    8 ++++----
> 2 files changed, 13 insertions(+), 11 deletions(-)
>
>Index: aic94xx-sas-2.6-patched/drivers/scsi/sas/sas_internal.h
>===================================================================
>--- aic94xx-sas-2.6-patched.orig/drivers/scsi/sas/sas_internal.h
>+++ aic94xx-sas-2.6-patched/drivers/scsi/sas/sas_internal.h
>@@ -27,6 +27,7 @@
> #define _SAS_INTERNAL_H_
>
> #include <scsi/sas/sas_class.h>
>+#include <linux/bitops.h>
> #include <scsi/scsi_host.h>
>
> #define sas_printk(fmt, ...) printk(KERN_NOTICE "sas: " fmt, ##
> __VA_ARGS__) @@ -70,28 +71,29 @@ void sas_notify_lldd_dev_gone(struct dom
>
> void sas_hae_reset(void *);
>
>-static inline void sas_queue_event(int event, spinlock_t *lock, u32
> *pending,
>-				   struct work_struct *work, 
>-				   struct Scsi_Host *shost)
>+static inline void sas_queue_event(int event, spinlock_t *lock, unsigned
>+				   long *pending, struct work_struct
>+				   *work, struct Scsi_Host *shost)

Line break in the middle of declarations? I would prefer if you would not do 
that.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]