From: Olof Johansson <olof@lixom.net>
To: Matheus Izvekov <mizvekov@gmail.com>
Cc: Daniel Walker <dwalker@mvista.com>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] mtd redboot (also gcc 4.1 warning fix)
Date: Tue, 9 May 2006 22:29:12 -0500 [thread overview]
Message-ID: <20060510032912.GC1794@lixom.net> (raw)
In-Reply-To: <305c16960605092014t240ece2ob620264501deaa39@mail.gmail.com>
On Wed, May 10, 2006 at 12:14:45AM -0300, Matheus Izvekov wrote:
> On 5/9/06, Daniel Walker <dwalker@mvista.com> wrote:
> >unsigned long may not always be 32 bits, right ? This patch fixes the
> Incorrect, its defined as 32bits for every standard C compiler
Wrong. The only environment I'm aware of that has only P64 is Win64.
Still, that's a bad patch, since it removes the warning without fixing
the bug. It's a valid warning, the underlying problem should be fixed
instead. It's better to keep the warning around until that's been done.
-Olof
next prev parent reply other threads:[~2006-05-10 3:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:56 [BUG] mtd redboot (also gcc 4.1 warning fix) Daniel Walker
2006-05-10 3:14 ` Matheus Izvekov
2006-05-10 3:20 ` Daniel Walker
2006-05-10 3:29 ` Olof Johansson [this message]
2006-05-10 3:31 ` Daniel Walker
2006-05-10 4:54 ` Matheus Izvekov
2006-05-10 9:04 ` Steven Rostedt
2006-05-10 5:37 ` Adrian Bunk
2006-05-10 9:00 ` Steven Rostedt
2006-05-10 14:43 ` Daniel Walker
2006-05-10 14:35 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510032912.GC1794@lixom.net \
--to=olof@lixom.net \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mizvekov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.