From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964930AbWEJLlY (ORCPT ); Wed, 10 May 2006 07:41:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964929AbWEJLlY (ORCPT ); Wed, 10 May 2006 07:41:24 -0400 Received: from smtp.osdl.org ([65.172.181.4]:59023 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964930AbWEJLlX (ORCPT ); Wed, 10 May 2006 07:41:23 -0400 Date: Wed, 10 May 2006 04:38:34 -0700 From: Andrew Morton To: Con Kolivas Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: cleanup swap unused warning Message-Id: <20060510043834.70f40ddc.akpm@osdl.org> In-Reply-To: <200605102132.41217.kernel@kolivas.org> References: <200605102132.41217.kernel@kolivas.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Con Kolivas wrote: > > Are there any users of swp_entry_t when CONFIG_SWAP is not defined? Well there shouldn't be. Making accesses to swp_entry_t.val fail to compile if !CONFIG_SWAP might be useful. > +/* > + * A swap entry has to fit into a "unsigned long", as > + * the entry is hidden in the "index" field of the > + * swapper address space. > + */ > +#ifdef CONFIG_SWAP > typedef struct { > unsigned long val; > } swp_entry_t; > +#else > +typedef struct { > + unsigned long val; > +} swp_entry_t __attribute__((__unused__)); > +#endif We have __attribute_used__, which hides a gcc oddity. From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 10 May 2006 04:38:34 -0700 From: Andrew Morton Subject: Re: [PATCH] mm: cleanup swap unused warning Message-Id: <20060510043834.70f40ddc.akpm@osdl.org> In-Reply-To: <200605102132.41217.kernel@kolivas.org> References: <200605102132.41217.kernel@kolivas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Con Kolivas Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Con Kolivas wrote: > > Are there any users of swp_entry_t when CONFIG_SWAP is not defined? Well there shouldn't be. Making accesses to swp_entry_t.val fail to compile if !CONFIG_SWAP might be useful. > +/* > + * A swap entry has to fit into a "unsigned long", as > + * the entry is hidden in the "index" field of the > + * swapper address space. > + */ > +#ifdef CONFIG_SWAP > typedef struct { > unsigned long val; > } swp_entry_t; > +#else > +typedef struct { > + unsigned long val; > +} swp_entry_t __attribute__((__unused__)); > +#endif We have __attribute_used__, which hides a gcc oddity. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org