From: Russell King <rmk@arm.linux.org.uk>
To: "George G. Davis" <gdavis@mvista.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [RFC][PATCH] Make sure UART is powered up when dumping MCTRL status
Date: Wed, 10 May 2006 17:39:19 +0100 [thread overview]
Message-ID: <20060510163919.GF32632@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060505221537.GK14872@mvista.com>
On Fri, May 05, 2006 at 06:15:37PM -0400, George G. Davis wrote:
> @@ -2068,6 +2076,10 @@ uart_configure_port(struct uart_driver *
>
> uart_report_port(drv, port);
>
> + /* Power up port for set_mctrl() */
> + if (!uart_console(port))
> + uart_change_pm(state, 0);
> +
If it's possible for uarts to be powered down here, wouldn't it be a
good idea to ensure that the console is also powered up?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-05-10 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-05 22:15 [RFC][PATCH] Make sure UART is powered up when dumping MCTRL status George G. Davis
2006-05-10 16:39 ` Russell King [this message]
2006-05-10 17:13 ` George G. Davis
2006-06-28 14:23 ` George G. Davis
2006-10-06 0:30 ` George G. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510163919.GF32632@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=gdavis@mvista.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.