All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
Cc: mikem@beardog.cca.cpqcorp.net, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, Andries.Brouwer@cwi.nl
Subject: Re: [PATCH] make kernel ignore bogus partitions
Date: Thu, 11 May 2006 04:00:14 -0700	[thread overview]
Message-ID: <20060511040014.66ea16fc.akpm@osdl.org> (raw)
In-Reply-To: <20060509224848.GA29754@apps.cwi.nl>

Andries Brouwer <Andries.Brouwer@cwi.nl> wrote:
>
> On Tue, May 09, 2006 at 12:41:38PM -0700, Andrew Morton wrote:
> 
> > > +		if (from+size-1 > get_capacity(disk)) {
> > > +			printk(" %s: p%d exceeds device capacity, ignoring.\n", 
> > > +				disk->disk_name, p);
> > > +			continue;
> > > +		}
> > >  		add_partition(disk, p, from, size);
> 
> > Shouldn't that be
> > 
> > 	if (from+size > get_capacity(disk)) {
> > 
> > ?
> 
> Ha, you are awake.

Opinions differ.

> Yes, it should.
> And no "ignoring". And no "continue". E.g.:
> 
> 	printk(" %s: warning: p%d exceeds device capacity.\n", ...);
> 

So you're saying that after detecting this inconsistency we should proceed
to use the partition anyway?

For what reason?

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: mikem@beardog.cca.cpqcorp.net, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, Andries.Brouwer@cwi.nl
Subject: Re: [PATCH] make kernel ignore bogus partitions
Date: Thu, 11 May 2006 04:00:14 -0700	[thread overview]
Message-ID: <20060511040014.66ea16fc.akpm@osdl.org> (raw)
In-Reply-To: <20060509224848.GA29754@apps.cwi.nl>

Andries Brouwer <Andries.Brouwer@cwi.nl> wrote:
>
> On Tue, May 09, 2006 at 12:41:38PM -0700, Andrew Morton wrote:
> 
> > > +		if (from+size-1 > get_capacity(disk)) {
> > > +			printk(" %s: p%d exceeds device capacity, ignoring.\n", 
> > > +				disk->disk_name, p);
> > > +			continue;
> > > +		}
> > >  		add_partition(disk, p, from, size);
> 
> > Shouldn't that be
> > 
> > 	if (from+size > get_capacity(disk)) {
> > 
> > ?
> 
> Ha, you are awake.

Opinions differ.

> Yes, it should.
> And no "ignoring". And no "continue". E.g.:
> 
> 	printk(" %s: warning: p%d exceeds device capacity.\n", ...);
> 

So you're saying that after detecting this inconsistency we should proceed
to use the partition anyway?

For what reason?

  reply	other threads:[~2006-05-11 11:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-03 21:00 [PATCH] make kernel ignore bogus partitions Mike Miller (OS Dev)
2006-05-08  7:27 ` Andries Brouwer
2006-05-08 15:00   ` Douglas Gilbert
2006-05-08 15:33   ` David Greaves
2006-05-08 20:20     ` Jan Engelhardt
2006-05-08 20:46       ` reiser4 bug [was Re: 2.6.17-rc3-mm1] Alexander Gran
2006-05-08 23:21         ` Joe Feise
2006-05-09  0:13           ` Alexander Gran
2006-05-09 19:41 ` [PATCH] make kernel ignore bogus partitions Andrew Morton
2006-05-09 22:48   ` Andries Brouwer
2006-05-11 11:00     ` Andrew Morton [this message]
2006-05-11 11:00       ` Andrew Morton
2006-05-11 11:51       ` Andries Brouwer
2006-05-11 16:04         ` Mike Miller (OS Dev)
2006-05-11 23:08         ` Daniel Barkalow
2006-05-12 10:32           ` Jan Engelhardt
2006-10-30 19:45             ` Phillip Susi
2006-10-30 21:48               ` Christian Schmidt
2006-05-11 21:47       ` Mike Miller (OS Dev)
2006-05-11 16:17   ` Mike Miller (OS Dev)
2006-05-11 16:27     ` Andrew Morton
2006-05-11 17:09       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060511040014.66ea16fc.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mikem@beardog.cca.cpqcorp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.