All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>,
	Erik Mouw <erik@harddisk-recovery.com>,
	Or Gerlitz <or.gerlitz@gmail.com>,
	linux-scsi@vger.kernel.org, axboe@suse.de,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache
Date: Fri, 12 May 2006 23:08:08 +0100	[thread overview]
Message-ID: <20060512220807.GR27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060512215520.GH17120@flint.arm.linux.org.uk>

On Fri, May 12, 2006 at 10:55:20PM +0100, Russell King wrote:
> On Fri, May 12, 2006 at 10:43:54PM +0100, Al Viro wrote:
> > On Fri, May 12, 2006 at 09:34:16PM +0100, Russell King wrote:
> > > On Fri, May 12, 2006 at 10:36:57AM -0700, Linus Torvalds wrote:
> > > > Yes. We could just revert that commit, but it seems correct, and I'd 
> > > > really like for somebody to understand _why_ that commit matters at all. I 
> > > > certainly don't see the overlap here..
> > > 
> > > Reverting the commit breaks MMC/SD in a very real way, and the fix
> > > is plainly correct and is actually the only possible fix that can be
> > > applied.
> > 
> > Bullshit.  Could you explain what generic code dereferences ->driverfs_dev
> > after del_gendisk()?  If you see such beast, please tell; _that_ is the
> > real bug.
> 
> Al, I think you're going to eat your own bull on this one.
> 
> You'll find that in the reply I've just sent to Linus - two oopen
> reported by two different people since the mount/umount hotplug
> events got re-merged.
> 
> The problem case is:
> 
> - insert card
> - mount filesystem
> - remove card
> - umount filesystem <bang, oops>
> 
> The generic code is block_uevent(), which is called at umount time
> _after_ the gendisk has been deleted (which happens when the card has
> been removed.)
> 
> Basically, you can't umount a destroyed block device without oopsing.

So block_uevent() is bogus; great, we've located the real bug.  The
real question: what uses these events and what can userland _do_ when
it gets something about a device that had been gone for a month?

Secondary question: who had resurrected that crap?  I distinctly remember
killing it off...

  reply	other threads:[~2006-05-12 22:08 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-11 15:14 [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Erik Mouw
2006-05-12  4:53 ` Or Gerlitz
2006-05-12 17:16   ` Erik Mouw
2006-05-12 17:27     ` Andrew Vasquez
2006-05-12 20:18       ` Erik Mouw
2006-05-12 17:36     ` Linus Torvalds
2006-05-12 17:47       ` James Bottomley
2006-05-12 18:58         ` James Bottomley
2006-05-12 19:09           ` Linus Torvalds
2006-05-12 20:38             ` Russell King
2006-05-12 20:50               ` Linus Torvalds
2006-05-12 20:58                 ` Russell King
2006-05-12 21:27                   ` Linus Torvalds
2006-05-12 21:46                     ` Linus Torvalds
2006-05-12 21:51                     ` Russell King
2006-05-12 22:15                       ` Linus Torvalds
2006-05-12 22:37                         ` Linus Torvalds
2006-05-12 23:57                           ` Greg KH
2006-05-14 16:01                             ` Russell King
2006-05-12 21:18                 ` Greg KH
2006-05-12 21:32                   ` Linus Torvalds
2006-05-12 22:45                     ` Greg KH
2006-05-12 20:52               ` Greg KH
2006-05-12 21:03                 ` Russell King
2006-05-12 21:34                   ` Greg KH
2006-05-12 21:39                   ` Al Viro
2006-05-12 20:30           ` Erik Mouw
2006-05-12 20:37           ` Russell King
2006-05-12 20:21       ` Erik Mouw
2006-05-12 20:34       ` Russell King
2006-05-12 21:43         ` Al Viro
2006-05-12 21:55           ` Russell King
2006-05-12 22:08             ` Al Viro [this message]
2006-05-12 22:22               ` Linus Torvalds
2006-05-12 22:28                 ` Al Viro
2006-05-12 22:48                   ` Al Viro
2006-05-12 22:51                     ` Al Viro
2006-05-12 23:04                       ` Linus Torvalds
2006-05-12 23:21                         ` Al Viro
2006-05-12 23:37                           ` Al Viro
2006-05-12 23:50                             ` Linus Torvalds
2006-05-13  0:20                               ` Al Viro
2006-05-24 14:07                               ` Erik Mouw
2006-05-13  0:08                   ` Greg KH
2006-05-12 22:37                 ` Russell King
2006-05-12 21:58           ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060512220807.GR27946@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=axboe@suse.de \
    --cc=erik@harddisk-recovery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=or.gerlitz@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.