From: Michael Buesch <mb@bu3sch.de>
To: Sergey Vlasov <vsu@altlinux.ru>
Cc: akpm@osdl.org, Deepak Saxena <dsaxena@plexity.net>,
bcm43xx-dev@lists.berlios.de, linux-kernel@vger.kernel.org
Subject: Re: [patch 3/9] Add Intel HW RNG driver
Date: Fri, 12 May 2006 22:48:38 +0200 [thread overview]
Message-ID: <200605122248.38797.mb@bu3sch.de> (raw)
In-Reply-To: <20060512110807.GB19254@master.mivlgu.local>
On Friday 12 May 2006 13:08, you wrote:
> > +static struct pci_device_id pci_tbl[] = {
>
> Should be const.
Sure, will fix that for every driver.
> > + for_each_pci_dev(pdev) {
> > + ent = pci_match_id(pci_tbl, pdev);
> > + if (ent)
> > + goto found;
> > + }
> > + /* Device not found. */
> > + goto out;
>
> if (!pci_dev_present(pci_tbl))
> goto out;
Good idea. I just copied the code from the old driver.
> > + err = hwrng_register(&intel_rng);
> > + if (err) {
> > + printk(KERN_ERR PFX "RNG registering failed (%d)\n",
> > + err);
> > + goto out;
>
> goto err_unmap;
oops.
--
Greetings Michael.
next prev parent reply other threads:[~2006-05-12 20:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-12 10:35 [patch 0/9] New Generic HW RNG (#3) mb
2006-05-12 10:35 ` [patch 1/9] Remove old HW RNG support mb
2006-05-12 10:35 ` [patch 2/9] Add new generic HW RNG core mb
2006-05-12 10:35 ` [patch 3/9] Add Intel HW RNG driver mb
2006-05-12 11:08 ` Sergey Vlasov
2006-05-12 20:48 ` Michael Buesch [this message]
2006-05-12 10:35 ` [patch 4/9] Add AMD " mb
2006-05-12 10:35 ` [patch 5/9] Add Geode " mb
2006-05-12 11:05 ` David Vrabel
2006-05-12 20:46 ` Michael Buesch
2006-05-12 21:06 ` David Vrabel
2006-05-15 15:35 ` Jordan Crouse
2006-05-12 10:35 ` [patch 6/9] Add VIA " mb
2006-05-12 10:35 ` [patch 7/9] Add ixp4xx " mb
2006-05-12 10:35 ` [patch 8/9] Add TI OMAP CPU family " mb
2006-05-12 10:35 ` [patch 9/9] Add bcm43xx HW RNG support mb
2006-05-12 15:16 ` Denis Vlasenko
2006-05-12 15:20 ` Johannes Berg
2006-05-12 20:51 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605122248.38797.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.