Re: [RFC] printks in print_inquiry

[Matthew Wilcox <matthew@wil.cx>]

On Fri, May 12, 2006 at 10:08:54AM -0700, Patrick Mansfield wrote:
> Terser one line output would be nice (even for a few devices), with "scsi"
> and bus_id. We don't need "Type", like:
> 
> SCSI 2:0:0:0: Vendor: FOO      Model: BAR              Rev: 0.2 ANSI rev: 04
> 
> And maybe use printk("%-16s") formatting? But garbage might get printed
> for non-ASCII (though the SCSI specs say it is not allowed ...).

I'm certainly in favour of changing the formatting; possibly even
eliminating it.  It gets very tiresome on a large system.  But then it's
sometimes useful, particularly in bug reports.  So eliminating it may
be a step too far.

> > the function says we should be packaging all this up into a hotplug
> > event.  Is that still true?  If so, I can do that, and we can forget
> > about this patch.
> 
> There is already a hotplug event. 
> 
> But the timing and output of it won't match well with the other SCSI (sd)
> messages, they'll likely be output before hotplug handling for the event.
> 
> And then if relying on udev for the output: it replays hotplug events when
> it starts up, so (AFAICT) you'd get a flurry of output after all the other
> scsi kernel messages for no udev in initrd and for monolithic kernels
> (well any time udev is started after scsi discovery).

I wasn't thinking about relying on it for the output; more that if the
data's being parsed out of the inquiry string already, doing this second
conversion in print_inquiry is a bit daft.  And ugly.  It'd be better to
take the constructed hotplug event and print the relevant fields out of
that.  I'll fiddle with it some more.