All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: apw@shadowen.org, linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: [PATCH] x86 NUMA panic compile error
Date: Mon, 15 May 2006 21:06:45 +0200	[thread overview]
Message-ID: <20060515190645.GA21899@elte.hu> (raw)
In-Reply-To: <20060515185657.GA19888@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> updated patch below. Or lets drop the original patch that adds the 
> panic?

another update: s/KERN_WARN/KERN_WARNING ...

	Ingo

---

re-enable dummy NUMA on i386.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

 arch/i386/kernel/srat.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Index: linux/arch/i386/kernel/srat.c
===================================================================
--- linux.orig/arch/i386/kernel/srat.c
+++ linux/arch/i386/kernel/srat.c
@@ -266,13 +266,12 @@ int __init get_memcfg_from_srat(void)
 	int tables = 0;
 	int i = 0;
 
+#ifdef CONFIG_X86_CYCLONE_TIMER
 	extern int use_cyclone;
-	if (use_cyclone == 0) {
-		/* Make sure user sees something */
-		static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else."
-		early_printk(s);
-		panic(s);
-	}
+	/* Make sure user sees something */
+	if (use_cyclone == 0)
+#endif
+		printk(KERN_WARNING "WARNING: Not an IBM x440/NUMAQ and CONFIG_NUMA enabled!\n");
 
 	if (ACPI_FAILURE(acpi_find_root_pointer(ACPI_PHYSICAL_ADDRESSING,
 						rsdp_address))) {

  reply	other threads:[~2006-05-15 19:06 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-15  7:56 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 10:09 ` 2.6.17-rc4-mm1 Eric Dumazet
2006-05-15 11:03   ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 11:42     ` 2.6.17-rc4-mm1 Pekka Enberg
2006-05-15 13:28     ` 2.6.17-rc4-mm1 Eric Dumazet
2006-05-15 13:12 ` 2.6.17-rc4-mm1 Reuben Farrelly
2006-05-15 22:09   ` 2.6.17-rc4-mm1 Neil Brown
2006-05-15 14:08 ` [PATCH] x86 NUMA panic compile error Andy Whitcroft
2006-05-15 17:53   ` Ingo Molnar
2006-05-15 18:01     ` Andi Kleen
2006-05-15 18:14       ` Ingo Molnar
2006-05-15 18:08     ` Andrew Morton
2006-05-15 18:08       ` Andy Whitcroft
2006-05-15 18:24         ` Andrew Morton
2006-05-15 18:24           ` Andi Kleen
2006-05-15 19:45           ` Martin Bligh
2006-05-15 18:13       ` Andi Kleen
2006-05-15 18:31         ` Ingo Molnar
2006-05-15 18:34         ` Andrew Morton
2006-05-15 18:37           ` Andi Kleen
2006-05-15 18:49             ` Ingo Molnar
2006-05-15 19:05             ` Dave Hansen
2006-05-15 19:11               ` Andi Kleen
2006-05-15 19:26                 ` Ingo Molnar
2006-05-15 19:38                   ` Andi Kleen
2006-05-16  7:06                     ` Ingo Molnar
2006-05-16  9:22                       ` Andi Kleen
2006-05-15 19:39                   ` Andrew Morton
2006-05-15 19:47                     ` Andi Kleen
2006-05-15 19:59                       ` Andrew Morton
2006-05-15 20:02                         ` Andi Kleen
2006-05-15 23:06                 ` H. Peter Anvin
2006-05-17  0:39                   ` Dave Jones
2006-05-17  1:21                     ` H. Peter Anvin
2006-05-15 18:43           ` Ingo Molnar
2006-05-15 18:28       ` Ingo Molnar
2006-05-15 18:52         ` Andrew Morton
2006-05-15 18:56           ` Andi Kleen
2006-05-15 18:59             ` Ingo Molnar
2006-05-15 18:56           ` Ingo Molnar
2006-05-15 19:06             ` Ingo Molnar [this message]
2006-05-15 16:40 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 16:40 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 17:04   ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 17:30     ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 17:30     ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 17:56       ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 18:11         ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-16  9:04           ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-16  9:04           ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 18:11         ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:50         ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:50         ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 17:56       ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 17:04   ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 16:49 ` 2.6.17-rc4-mm1 Alexey Dobriyan
2006-05-15 17:01   ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:01     ` 2.6.17-rc4-mm1 Alexey Dobriyan
2006-05-15 19:29     ` 2.6.17-rc4-mm1 Michael Halcrow
2006-05-15 17:48 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:00   ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:05 ` 2.6.17-rc4-mm1 Jesper Juhl
2006-05-15 18:37 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:53   ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 19:10     ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 19:26       ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 20:17         ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-16  8:39           ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 12:55             ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 14:48               ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 15:18                 ` 2.6.17-rc4-mm1 Stephen Hemminger
2006-05-16 15:23                 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 16:08                   ` 2.6.17-rc4-mm1 Greg KH
2006-05-16 16:27                     ` 2.6.17-rc4-mm1 Stephen Hemminger
2006-05-16 16:49                       ` 2.6.17-rc4-mm1 Greg KH
2006-05-15 19:28 ` 2.6.17-rc4-mm1 Ingo Molnar
     [not found] ` <6bffcb0e0605151003x5d3518b9o70dae3b3349c4f9f@mail.gmail.com>
2006-05-15 22:24   ` 2.6.17-rc4-mm1 David Woodhouse
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
2006-05-16 10:25   ` Adrian Bunk
2006-05-16 12:13   ` David Woodhouse
2006-05-16 12:13     ` David Woodhouse
2006-05-16 11:46 ` [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's Adrian Bunk
2006-05-16 11:46   ` Adrian Bunk
2006-05-16 12:14   ` David Woodhouse
2006-05-16 12:14     ` David Woodhouse
2006-05-16 11:48 ` [-mm patch] make dvb/b2c2/flexcop-fe-tuner.c:alps_tdee4_stv0297_tuner_set_params() static Adrian Bunk
2006-05-16 12:15 ` [-mm patch] drivers/media/video/pwc/: make code static Adrian Bunk
2006-05-16 12:32 ` [-mm patch] make variables static after klibc merge Adrian Bunk
2006-05-16 12:37 ` [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static Adrian Bunk
2006-05-16 12:37   ` Adrian Bunk
2006-05-16 13:04   ` David Woodhouse
2006-05-16 13:04     ` David Woodhouse
2006-05-16 12:39 ` [-mm patch] fs/nfs/: make code static Adrian Bunk
2006-05-16 13:24 ` [-mm patch] arch/i386/oprofile/: make functions static Adrian Bunk
2006-05-16 18:16   ` Andi Kleen
2006-05-16 19:07   ` Andi Kleen
2006-05-16 15:26 ` [Ocfs2-devel] [-mm patch] fs/ocfs2/dlm/: cleanups Adrian Bunk
2006-05-16 15:26   ` Adrian Bunk
2006-05-17  1:36   ` [Ocfs2-devel] " Mark Fasheh
2006-05-17  1:36     ` Mark Fasheh
2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk
2006-05-16 15:36   ` Andreas Mohr
2006-05-16 16:42     ` Adrian Bunk
2006-05-24  5:28   ` Jeff Garzik
2006-05-16 16:12 ` 2.6.17-rc4-mm1: please drop add-raw-driver-kconfig-entry-for-s390.patch Adrian Bunk
2006-05-16 16:37   ` Olaf Hering
2006-05-16 17:44     ` [2.6 patch] the overdue removal of the obsolete raw driver Adrian Bunk
2006-05-16 17:50       ` Olaf Hering
2006-05-17 13:12   ` 2.6.17-rc4-mm1: please drop add-raw-driver-kconfig-entry-for-s390.patch Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060515190645.GA21899@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.