From: Alan Cox <alan@redhat.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Moxa Technologies <support@moxa.com.tw>,
Alan Cox <alan@redhat.com>, Martin Mares <mj@ucw.cz>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 1/3] moxa: remove pointless casts
Date: Mon, 15 May 2006 17:57:51 -0400 [thread overview]
Message-ID: <20060515215751.GA16994@devserv.devel.redhat.com> (raw)
In-Reply-To: <200605152357.19218.jesper.juhl@gmail.com>
On Mon, May 15, 2006 at 11:57:18PM +0200, Jesper Juhl wrote:
>
> Remove a bunch of pointless casts from moxa driver.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
> ---
>
> drivers/char/mxser.c | 42 +++++++++++++++++++++---------------------
> 1 files changed, 21 insertions(+), 21 deletions(-)
>
> --- linux-2.6.17-rc4-mm1-orig/drivers/char/mxser.c 2006-05-13 21:28:25.000000000 +0200
> +++ linux-2.6.17-rc4-mm1/drivers/char/mxser.c 2006-05-15 22:32:50.000000000 +0200
> @@ -877,7 +877,7 @@ static int mxser_init(void)
>
> static void mxser_do_softint(void *private_)
> {
> - struct mxser_struct *info = (struct mxser_struct *) private_;
> + struct mxser_struct *info = private_;
> struct tty_struct *tty;
>
> tty = info->tty;
> @@ -972,7 +972,7 @@ static int mxser_open(struct tty_struct
> */
> static void mxser_close(struct tty_struct *tty, struct file *filp)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
>
> unsigned long timeout;
> unsigned long flags;
> @@ -1078,7 +1078,7 @@ static void mxser_close(struct tty_struc
> static int mxser_write(struct tty_struct *tty, const unsigned char *buf, int count)
> {
> int c, total = 0;
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> if (!tty || !info->xmit_buf)
> @@ -1114,7 +1114,7 @@ static int mxser_write(struct tty_struct
>
> static void mxser_put_char(struct tty_struct *tty, unsigned char ch)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> if (!tty || !info->xmit_buf)
> @@ -1141,7 +1141,7 @@ static void mxser_put_char(struct tty_st
>
> static void mxser_flush_chars(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> if (info->xmit_cnt <= 0 || tty->stopped || !info->xmit_buf || (tty->hw_stopped && (info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag)))
> @@ -1157,7 +1157,7 @@ static void mxser_flush_chars(struct tty
>
> static int mxser_write_room(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> int ret;
>
> ret = SERIAL_XMIT_SIZE - info->xmit_cnt - 1;
> @@ -1168,13 +1168,13 @@ static int mxser_write_room(struct tty_s
>
> static int mxser_chars_in_buffer(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> return info->xmit_cnt;
> }
>
> static void mxser_flush_buffer(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> char fcr;
> unsigned long flags;
>
> @@ -1197,7 +1197,7 @@ static void mxser_flush_buffer(struct tt
>
> static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> int retval;
> struct async_icount cprev, cnow; /* kernel counter temps */
> struct serial_icounter_struct __user *p_cuser;
> @@ -1581,7 +1581,7 @@ static int mxser_ioctl_special(unsigned
>
> static void mxser_stoprx(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> //unsigned long flags;
>
>
> @@ -1615,7 +1615,7 @@ static void mxser_stoprx(struct tty_stru
>
> static void mxser_startrx(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> //unsigned long flags;
>
> info->ldisc_stop_rx = 0;
> @@ -1656,7 +1656,7 @@ static void mxser_startrx(struct tty_str
> */
> static void mxser_throttle(struct tty_struct *tty)
> {
> - //struct mxser_struct *info = (struct mxser_struct *)tty->driver_data;
> + //struct mxser_struct *info = tty->driver_data;
> //unsigned long flags;
> //MX_LOCK(&info->slock);
> mxser_stoprx(tty);
> @@ -1665,7 +1665,7 @@ static void mxser_throttle(struct tty_st
>
> static void mxser_unthrottle(struct tty_struct *tty)
> {
> - //struct mxser_struct *info = (struct mxser_struct *)tty->driver_data;
> + //struct mxser_struct *info = tty->driver_data;
> //unsigned long flags;
> //MX_LOCK(&info->slock);
> mxser_startrx(tty);
> @@ -1674,7 +1674,7 @@ static void mxser_unthrottle(struct tty_
>
> static void mxser_set_termios(struct tty_struct *tty, struct termios *old_termios)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> if ((tty->termios->c_cflag != old_termios->c_cflag) || (RELEVANT_IFLAG(tty->termios->c_iflag) != RELEVANT_IFLAG(old_termios->c_iflag))) {
> @@ -1711,7 +1711,7 @@ static void mxser_set_termios(struct tty
> */
> static void mxser_stop(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> spin_lock_irqsave(&info->slock, flags);
> @@ -1724,7 +1724,7 @@ static void mxser_stop(struct tty_struct
>
> static void mxser_start(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> spin_lock_irqsave(&info->slock, flags);
> @@ -1740,7 +1740,7 @@ static void mxser_start(struct tty_struc
> */
> static void mxser_wait_until_sent(struct tty_struct *tty, int timeout)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long orig_jiffies, char_time;
> int lsr;
>
> @@ -1803,7 +1803,7 @@ static void mxser_wait_until_sent(struct
> */
> void mxser_hangup(struct tty_struct *tty)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
>
> mxser_flush_buffer(tty);
> mxser_shutdown(info);
> @@ -1821,7 +1821,7 @@ void mxser_hangup(struct tty_struct *tty
> */
> static void mxser_rs_break(struct tty_struct *tty, int break_state)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
> spin_lock_irqsave(&info->slock, flags);
> @@ -2886,7 +2886,7 @@ static void mxser_send_break(struct mxse
>
> static int mxser_tiocmget(struct tty_struct *tty, struct file *file)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned char control, status;
> unsigned long flags;
>
> @@ -2909,7 +2909,7 @@ static int mxser_tiocmget(struct tty_str
>
> static int mxser_tiocmset(struct tty_struct *tty, struct file *file, unsigned int set, unsigned int clear)
> {
> - struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
> + struct mxser_struct *info = tty->driver_data;
> unsigned long flags;
>
>
>
>
--
--
In Ximian did mad Miguel a mighty mail client decree
Where Nat the crazy hacker ran
Through sourcecode measureless to man
And never coredump free
prev parent reply other threads:[~2006-05-15 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 21:57 [PATCH 1/3] moxa: remove pointless casts Jesper Juhl
2006-05-15 21:57 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060515215751.GA16994@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=adobriyan@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=support@moxa.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.