From: christoph <hch@lst.de>
To: Nathan Scott <nathans@sgi.com>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
akpm@osdl.org, christoph <hch@lst.de>,
Benjamin LaHaise <bcrl@kvack.org>,
cel@citi.umich.edu, Zach Brown <zach.brown@oracle.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups
Date: Tue, 16 May 2006 12:50:43 +0200 [thread overview]
Message-ID: <20060516105042.GA18214@lst.de> (raw)
In-Reply-To: <20060516082804.F5598@wobbly.melbourne.sgi.com>
On Tue, May 16, 2006 at 08:28:04AM +1000, Nathan Scott wrote:
> I know its not something you're introducing here, but the naming
> convention do_sync_read/do_sync_write is pretty confused (with it
> not actually being a sync write and all, in the usual case).
> Any chance that could be renamed to something thats a bit clearer,
> maybe generic_file_non_aio_read and generic_file_non_aio_write?
> There don't seem to be many callsites (so not a huge change) and
> it'd seem a good time to do it, alongside these other changes.
I agree that the current naming is rather odd. generic_file_* on the
other hand would be completely wrong - generic_file_* are the generic
pagecache routines, these are wrappers to use ->aio_read/->aio_write.
Currently I can't imagine a better name, though.
next prev parent reply other threads:[~2006-05-16 10:51 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 15:07 [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Badari Pulavarty
2006-05-02 15:08 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-02 15:20 ` Chuck Lever
2006-05-02 15:35 ` Badari Pulavarty
2006-05-02 15:09 ` [PATCH 2/3] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-02 15:11 ` [PATCH 3/3] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-09 18:03 ` [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Badari Pulavarty
2006-05-09 18:07 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-09 19:01 ` Andrew Morton
2006-05-09 19:03 ` Christoph Hellwig
2006-05-09 19:13 ` Andrew Morton
2006-05-09 19:20 ` Christoph Hellwig
2006-05-09 23:57 ` Badari Pulavarty
2006-05-10 8:00 ` Christoph Hellwig
2006-05-10 15:01 ` Badari Pulavarty
2006-05-10 16:01 ` Badari Pulavarty
2006-05-10 20:50 ` Badari Pulavarty
2006-05-09 20:07 ` Badari Pulavarty
2006-05-09 23:53 ` Badari Pulavarty
2006-05-09 18:07 ` [PATCH 2/3] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-09 18:08 ` [PATCH 3/3] Zach's core aio changes to support vectored AIO Badari Pulavarty
2006-05-09 18:55 ` christoph
2006-05-09 20:05 ` Badari Pulavarty
2006-05-09 18:14 ` [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Benjamin LaHaise
2006-05-11 15:38 ` [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-05-11 15:38 ` [PATCH 1/4] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-11 18:39 ` Andrew Morton
2006-05-11 19:33 ` Mark Fasheh
2006-05-11 18:47 ` Andrew Morton
2006-05-11 19:07 ` Badari Pulavarty
2006-05-11 20:21 ` Andrew Morton
2006-05-11 20:45 ` Badari Pulavarty
[not found] ` <4463AB55.2010105@citi.umich.edu>
[not found] ` <4463B368.9050602@us.ibm.com>
[not found] ` <4463B7B0.4000102@citi.umich.edu>
2006-05-11 22:50 ` Badari Pulavarty
2006-05-12 7:38 ` Christoph Hellwig
2006-05-11 18:52 ` Andrew Morton
2006-05-11 19:12 ` Badari Pulavarty
2006-05-12 10:03 ` Andrew Morton
2006-05-12 10:08 ` Andrew Morton
2006-05-12 13:56 ` Badari Pulavarty
2006-05-11 15:40 ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-11 15:42 ` [PATCH 3/4] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-11 15:43 ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-05-15 21:19 ` [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-05-15 21:21 ` [PATCH 1/4] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-15 21:22 ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-22 1:00 ` Andrew Morton
2006-05-22 4:39 ` Badari Pulavarty
2006-05-22 5:34 ` Christoph Hellwig
2006-05-22 8:16 ` Ian Kent
2006-05-22 8:19 ` Ian Kent
2006-05-22 9:29 ` Andrew Morton
2006-05-22 9:35 ` Andrew Morton
2006-05-22 10:32 ` Christoph Hellwig
2006-05-22 10:44 ` Andrew Morton
2006-05-22 10:50 ` Ian Kent
2006-05-22 15:24 ` Badari Pulavarty
2006-05-22 15:00 ` Badari Pulavarty
2006-05-22 17:06 ` Andrew Morton
2006-05-22 17:24 ` Badari Pulavarty
2006-05-23 8:29 ` Ian Kent
2006-05-23 14:35 ` Ian Kent
2006-05-28 0:15 ` Badari Pulavarty
2006-05-29 7:06 ` Ian Kent
2006-05-15 21:22 ` [PATCH 3/4] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-15 21:23 ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-05-15 22:28 ` Nathan Scott
2006-05-15 22:42 ` Andrew Morton
2006-05-15 22:56 ` Nathan Scott
2006-05-15 22:47 ` Badari Pulavarty
2006-05-16 10:50 ` christoph [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-02 19:06 [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO (2.6.17-rc5-mm2) Badari Pulavarty
2006-06-02 19:10 ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-06-13 23:32 [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-06-13 23:36 ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516105042.GA18214@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=cel@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=pbadari@us.ibm.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.