From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbWEPOjr (ORCPT ); Tue, 16 May 2006 10:39:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751156AbWEPOjr (ORCPT ); Tue, 16 May 2006 10:39:47 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:48528 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S1751154AbWEPOjr (ORCPT ); Tue, 16 May 2006 10:39:47 -0400 Date: Tue, 16 May 2006 16:39:37 +0200 From: Ingo Molnar To: Jan Beulich Cc: Andreas Kleen , linux-kernel@vger.kernel.org, discuss@x86-64.org, Andrew Morton Subject: Re: [PATCH 1/3] reliable stack trace support Message-ID: <20060516143937.GA10760@elte.hu> References: <4469FC07.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4469FC07.76E4.0078.0@novell.com> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: -2.8 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.8 required=5.9 tests=ALL_TRUSTED,AWL autolearn=no SpamAssassin version=3.0.3 -2.8 ALL_TRUSTED Did not pass through any untrusted hosts 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Jan Beulich wrote: > These are the generic bits needed to enable reliable stack traces > based on Dwarf2-like (.eh_frame) unwind information. Subsequent > patches will enable x86-64 and i386 to make use of this. really nice! > +config STACK_UNWIND > + bool "Stack unwind support" > + depends on UNWIND_INFO > + depends on n 'depends on n' ? Also, i think this should be 'default y'. The code is very clean. Curious: how much testing has it seen? Ingo