From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen Date: Tue, 16 May 2006 14:57:08 +0200 Message-ID: <200605161457.09187.ak@suse.de> References: <20060501215648.GU16776@us.ibm.com> <200605152246.30374.ak@suse.de> <25076f74e546e868c489e384ee838e2e@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <25076f74e546e868c489e384ee838e2e@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Xen Devel , Ryan Grimm , Ryan Harper List-Id: xen-devel@lists.xenproject.org > Yes, my gut feeling looking at x86_64's numa.c is that it's going to > need some heavier surgery than srat.c. I wouldn't worry so much about > keeping that one close to the Linux original: if we end up pulling down > more Linux memory bookkeeping code later then we can always go back and > sync the file more closely. Keep it as clean as possible though, > obviously (e.g., replacing whole functions is nicer than functions that > are a hacky halfway house between Linux and Xen, etc). If it helps I can split these functions into smaller ones in the mainline sources. That could isolate the pglists in only very small functions. -Andi