All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Mansfield <patmans@us.ibm.com>
To: James Smart <James.Smart@Emulex.Com>
Cc: Michael Reed <mdr@sgi.com>, linux-scsi@vger.kernel.org
Subject: Re: [REPOST][PATCH] update max sdev block limit
Date: Tue, 16 May 2006 09:34:50 -0700	[thread overview]
Message-ID: <20060516163450.GA25071@us.ibm.com> (raw)
In-Reply-To: <4469F83F.4030407@emulex.com>

On Tue, May 16, 2006 at 12:05:19PM -0400, James Smart wrote:
> I don't mind making it bigger, especially as this is just a max, not the
> default value. I tried to keep it low, as I believe even 2 mins is a long
> time from the system's perspective. 10 minutes is forever (and remember
> the scan deadlock that we just worked through).

Yes, so add default and max settings instead of using the max as the default.

And I still don't see how the scsi timeout can (reliably) make it through
these block/unblocks. EH_RESET_TIMER doesn't freeze the scsi timeout like
you really need, just restarts it. 

For example, with default sd timeout of 30, you could be one second into a
command, block for 28 seconds, unblock, and then still timeout.

-- Patrick Mansfield

  reply	other threads:[~2006-05-16 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-11 14:42 [REPOST][PATCH] update max sdev block limit James Smart
2006-05-16 15:09 ` Michael Reed
2006-05-16 16:05   ` James Smart
2006-05-16 16:34     ` Patrick Mansfield [this message]
2006-05-16 18:14       ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060516163450.GA25071@us.ibm.com \
    --to=patmans@us.ibm.com \
    --cc=James.Smart@Emulex.Com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mdr@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.