From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [PATCH] Make number of IDE interfaces configurable Date: Tue, 16 May 2006 18:40:11 +0200 Message-ID: <20060516164011.GH5677@stusta.de> References: <20060512222952.GQ6616@waste.org> <20060516160250.GE5677@stusta.de> <20060516162934.GR24227@waste.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from emailhub.stusta.mhn.de ([141.84.69.5]:44550 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932134AbWEPQkN (ORCPT ); Tue, 16 May 2006 12:40:13 -0400 Content-Disposition: inline In-Reply-To: <20060516162934.GR24227@waste.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Matt Mackall Cc: akpm@osdl.org, B.Zolnierkiewicz@elka.pw.edu.pl, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, May 16, 2006 at 11:29:34AM -0500, Matt Mackall wrote: > On Tue, May 16, 2006 at 06:02:50PM +0200, Adrian Bunk wrote: > > On Fri, May 12, 2006 at 05:29:52PM -0500, Matt Mackall wrote: > > >... > > > --- 2.6.orig/include/linux/ide.h 2006-05-11 15:07:32.000000000 -0500 > > > +++ 2.6/include/linux/ide.h 2006-05-12 14:01:53.000000000 -0500 > > > @@ -252,7 +252,8 @@ static inline void ide_std_init_ports(hw > > > > > > #include > > > > > > -#ifndef MAX_HWIFS > > > +#if !defined(MAX_HWIFS) || defined(CONFIG_EMBEDDED) > > > +#undef MAX_HWIFS > > > #define MAX_HWIFS CONFIG_IDE_MAX_HWIFS > > > #endif > > > > Why do you need this? > > Doesn't work without it? > > Most platforms define MAX_HWIFS. OK, now I got it. Setting this value is sometimes done in heder files and sometimes done in the Kconfig file. That is extremely ugly. Bart, would you accept a patch to set in in the Kconfig file on all architectures? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed