Re: [PATCH 2/3] reliable stack trace support (x86-64)

[Andi Kleen <ak@suse.de>]

On Tuesday 16 May 2006 16:21, Jan Beulich wrote:
> These are the x86_64-specific pieces to enable reliable stack traces. The
> only restriction with this is that it currently cannot unwind across the
> interrupt->normal stack boundary, as that transition is lacking proper
> annotation.

It would be nice if you could submit a patch to fix that.


>  
> +#ifdef CONFIG_STACK_UNWIND
> +  . = ALIGN(8);
> +  .eh_frame : AT(ADDR(.eh_frame) - LOAD_OFFSET) {
> +	__start_unwind = .;
> +  	*(.eh_frame)
> +	__end_unwind = .;
> +  }
> +#endif

Ah ok - it's there. Ignore my earlier question then.



> +#define UNW_PC(frame) (frame)->regs.rip
> +#define UNW_SP(frame) (frame)->regs.rsp

I think we alreay have instruction_pointer(). Better add a stack_pointer() 
in ptrace.h too.

-Andi