From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [PATCH 3/3] reliable stack trace support (i386)
Date: Tue, 16 May 2006 17:15:11 +0200 [thread overview]
Message-ID: <200605161715.11405.ak@suse.de> (raw)
In-Reply-To: <4469FC41.76E4.0078.0@novell.com>
On Tuesday 16 May 2006 16:22, Jan Beulich wrote:
> These are the i386-specific pieces to enable reliable stack traces. This is
> going to be even more useful once CFI annotations get added to he assembly
> code, namely to entry.S (a patch for that had been submitted several times).
Yes we should merge that. Can you resend it please?
> +static asmlinkage void show_trace_unwind(struct unwind_frame_info *info, void *log_lvl)
static asmlinkage ?
> +#define UNW_PC(frame) (frame)->regs.eip
> +#define UNW_SP(frame) (frame)->regs.esp
> +#ifdef CONFIG_FRAME_POINTER
> +#define UNW_FP(frame) (frame)->regs.ebp
> +#define FRAME_RETADDR_OFFSET 4
> +#define FRAME_LINK_OFFSET 0
> +#define STACK_BOTTOM(tsk) (((tsk)->thread.esp0 - 1) & ~(THREAD_SIZE - 1))
> +#define STACK_TOP(tsk) ((tsk)->thread.esp0)
> +#endif
Same comments as for x86-64
-Andi
next prev parent reply other threads:[~2006-05-16 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 14:22 [PATCH 3/3] reliable stack trace support (i386) Jan Beulich
2006-05-16 15:14 ` Ingo Molnar
2006-05-16 15:20 ` [discuss] " Andi Kleen
2006-05-16 15:15 ` Andi Kleen [this message]
2006-05-16 16:07 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605161715.11405.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.