From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by
Date: Tue, 16 May 2006 22:10:05 +0000 [thread overview]
Message-ID: <20060516221005.GA5340@kroah.com> (raw)
In-Reply-To: <446A4ADA.3070606@yahoo.fr>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Tue, May 16, 2006 at 11:57:46PM +0200, trem wrote:
> From: trem <tremyfr@yahoo.fr>
>
> This patch simply change pci_find_device by pci_get_device, because
> pci_find_device is deprecated. pci_dev_put has been added to decrement
> the counter, so unload could be done.
Huh? No, this patch is wrong, you are leaking a reference count, and
causing others to drop down to 0 accidentally.
Do NOT apply this.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-05-16 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 21:57 [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by trem
2006-05-16 22:10 ` Greg KH [this message]
2006-05-16 22:45 ` trem
2006-05-17 0:18 ` Greg KH
2006-05-20 0:50 ` [KJ] [PATCH] drivers/char/istallion.c : replace " trem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516221005.GA5340@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.