All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/char/ip2/ip2main.c : change pci_find_device
Date: Wed, 17 May 2006 00:19:42 +0000	[thread overview]
Message-ID: <20060517001942.GD6355@kroah.com> (raw)
In-Reply-To: <446A4AA3.7090202@zarb.org>

[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]

On Tue, May 16, 2006 at 11:56:51PM +0200, trem wrote:
> From: trem <tremyfr@yahoo.fr>
> 
> This patch simply change pci_find_device by pci_get_device, because
> pci_find_device is deprecated. pci_dev_put has been added to decrement
> the counter, so unload could be done.
> 
> Signed-Off-By: trem <tremyfr@yahoo.fr>
> ---
> 

> diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c
> index 03db1cb..2acdfb2 100644
> --- a/drivers/char/ip2/ip2main.c
> +++ b/drivers/char/ip2/ip2main.c
> @@ -594,7 +594,7 @@ ip2_loadmain(int *iop, int *irqp, unsign
>  #ifdef CONFIG_PCI
>  			{
>  				struct pci_dev *pci_dev_i = NULL;
> -				pci_dev_i = pci_find_device(PCI_VENDOR_ID_COMPUTONE,
> +				pci_dev_i = pci_get_device(PCI_VENDOR_ID_COMPUTONE,
>  							  PCI_DEVICE_ID_COMPUTONE_IP2EX, pci_dev_i);
>  				if (pci_dev_i != NULL) {
>  					unsigned int addr;
> @@ -622,6 +622,7 @@ ip2_loadmain(int *iop, int *irqp, unsign
>  //						pci_irq = 0;
>  //					}
>  					ip2config.irq[i] = pci_dev_i->irq;
> +					pci_dev_put(pci_dev_i);

Nope, you saved a reference and yet just released it.  Not acceptable.

Please note that making these changes is very difficult.  Numerous
people have tried it in the past and generally just given up.  See the
archives for details on how to get it correct, and to keep from doing
the same things that others did.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2006-05-17  0:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16 21:56 [KJ] [PATCH] drivers/char/ip2/ip2main.c : change pci_find_device by trem
2006-05-16 22:53 ` trem
2006-05-17  0:16 ` [KJ] [PATCH] drivers/char/ip2/ip2main.c : change pci_find_device Greg KH
2006-05-17  0:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060517001942.GD6355@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.