From: Jens Axboe <axboe@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] fs/bio.c: possible cleanups
Date: Wed, 17 May 2006 09:01:04 +0200 [thread overview]
Message-ID: <20060517070103.GB4197@suse.de> (raw)
In-Reply-To: <20060516184850.GR10077@stusta.de>
On Tue, May 16 2006, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make the follwing needlessly global function static:
> - __bio_clone()
NAK, it's part of the API (and I just had to use it the other day with
fcache).
> - don't mark the following _global_ functions as inline:
> - bio_phys_segments()
> - bio_hw_segments()
Ack.
> - remove the following unused EXPORT_SYMBOL's:
> - bio_phys_segments
> - bio_hw_segments
> - bio_map_kern
> - bio_copy_user
> - bio_uncopy_user
NAK, also part of the API. Leave them.
--
Jens Axboe
next prev parent reply other threads:[~2006-05-17 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 18:48 [RFC: 2.6 patch] fs/bio.c: possible cleanups Adrian Bunk
2006-05-17 7:01 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-23 11:33 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517070103.GB4197@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.