From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Lucas Date: Thu, 18 May 2006 08:35:22 +0000 Subject: Re: [KJ] [PATCH] printk : arch/arm/mach-omap1/board-osk.c Message-Id: <20060518083522.GH7899@rotomalug.org> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============31667827008618854==" List-Id: References: <20060515121824.GM12726@rotomalug.org> In-Reply-To: <20060515121824.GM12726@rotomalug.org> To: kernel-janitors@vger.kernel.org --===============31667827008618854== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Arthur Othieno (apgo@patchbomb.org) wrote: > On Mon, May 15, 2006 at 04:34:45PM +0200, Christophe Lucas wrote: > > Description: > > printk should include appropriate KERN_* constant (of course > > only at beginning of lines). > > > > Signed-off-by: Christophe Lucas > > > > > > Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c > > =================================================================== > > --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c 2006-05-11 03:56:24.000000000 +0200 > > +++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c 2006-05-15 12:27:32.000000000 +0200 > > @@ -148,7 +148,7 @@ > > static void __init osk_init_smc91x(void) > > { > > if ((omap_request_gpio(0)) < 0) { > > - printk("Error requesting gpio 0 for smc91x irq\n"); > > + printk(KERN_WARNING "Error requesting gpio 0 for smc91x irq\n"); > > KERN_ERR > > > return; > > } > > > > @@ -160,7 +160,7 @@ > > { > > omap_cfg_reg(M7_1610_GPIO62); > > if ((omap_request_gpio(62)) < 0) { > > - printk("Error requesting gpio 62 for CF irq\n"); > > + printk(KERN_WARNING "Error requesting gpio 62 for CF irq\n"); > > Ditto. > > > return; > > } > > /* the CF I/O IRQ is really active-low */ Here it is the corriged version : Description: printk should include appropriate KERN_* constant (of course only at beginning of lines). Signed-off-by: Christophe Lucas Index: linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c =================================================================== --- linux-2.6.16.16.orig/arch/arm/mach-omap1/board-osk.c 2006-05-18 10:22:59.000000000 +0200 +++ linux-2.6.16.16/arch/arm/mach-omap1/board-osk.c 2006-05-18 10:33:55.000000000 +0200 @@ -148,7 +148,7 @@ static void __init osk_init_smc91x(void) { if ((omap_request_gpio(0)) < 0) { - printk("Error requesting gpio 0 for smc91x irq\n"); + printk(KERN_ERR "Error requesting gpio 0 for smc91x irq\n"); return; } @@ -160,7 +160,7 @@ { omap_cfg_reg(M7_1610_GPIO62); if ((omap_request_gpio(62)) < 0) { - printk("Error requesting gpio 62 for CF irq\n"); + printk(KERN_ERR "Error requesting gpio 62 for CF irq\n"); return; } /* the CF I/O IRQ is really active-low */ --===============31667827008618854== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors --===============31667827008618854==--