From: Con Kolivas <kernel@kolivas.org>
To: linux kernel mailing list <linux-kernel@vger.kernel.org>,
ck list <ck@vds.kolivas.org>, Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Subject: [PATCH] mm: swap prefetch fix lowmem reserve calc
Date: Thu, 18 May 2006 15:58:57 +1000 [thread overview]
Message-ID: <200605181558.57777.kernel@kolivas.org> (raw)
When examining the free limits in swap_prefetch we should ensure the largest
lowmem_reserve for each zone is free.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
---
mm/swap_prefetch.c | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletion(-)
Index: linux-2.6.17-rc4-mm1/mm/swap_prefetch.c
===================================================================
--- linux-2.6.17-rc4-mm1.orig/mm/swap_prefetch.c 2006-05-18 15:48:22.000000000 +1000
+++ linux-2.6.17-rc4-mm1/mm/swap_prefetch.c 2006-05-18 15:52:42.000000000 +1000
@@ -258,6 +258,18 @@ static void clear_current_prefetch_free(
}
}
+static inline unsigned long largest_lowmem_reserve(struct zone *z)
+{
+ unsigned long ret = 0;
+ unsigned int idx = zone_idx(z);
+
+ while (!is_highmem_idx(idx)) {
+ idx++;
+ ret = max(ret, z->lowmem_reserve[idx]);
+ }
+ return ret;
+}
+
/*
* This updates the high and low watermarks of amount of free ram in each
* node used to start and stop prefetching. We prefetch from pages_high * 4
@@ -276,7 +288,7 @@ static void examine_free_limits(void)
ns = &sp_stat.node[z->zone_pgdat->node_id];
idx = zone_idx(z);
- ns->lowfree[idx] = z->pages_high * 3 + z->lowmem_reserve[idx];
+ ns->lowfree[idx] = z->pages_high * 3 + largest_lowmem_reserve(z);
ns->highfree[idx] = ns->lowfree[idx] + z->pages_high;
if (z->free_pages > ns->highfree[idx]) {
--
-ck
next reply other threads:[~2006-05-18 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 5:58 Con Kolivas [this message]
2006-05-18 7:18 ` [PATCH] mm: swap prefetch fix lowmem reserve calc Nick Piggin
2006-05-18 7:42 ` [PATCH][respin] " Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605181558.57777.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.