Re: [BUG] "stg pull" on qgit tree shows problems, including git-http-fetch segfault

[Yann Dirson <ydirson@altern.org>]

Let's be more precise - the command that repedetly fails is the
following.  It is reponsible for both the "XML error" message and the
segfault.

git-http-fetch -v -a 79ac640b3129344d4e94573ddaea09ccda1b8e3b http://digilander.libero.it/mcostalba/scm/qgit.git/


Output goes like:

walk 79ac640b3129344d4e94573ddaea09ccda1b8e3b
walk d8bc846d8d2709fa240887da512e8b125a669006
walk 5d0d2f1703976e04c6db1e55ea6a044981b9ed20
error: File f7dc43059ca42dec2ea7214a33d1ff3c35e0aca5 (http://digilander.libero.it/mcostalba/scm/qgit.git/objects/f7/dc43059ca42dec2ea7214a33d1ff3c35e0aca5) corrupt
Getting pack list for http://digilander.libero.it/mcostalba/scm/qgit.git/
error: XML error: syntax error
Getting index for pack c47999034002469dddee39ba0069c1b1a84487a5
error: Unable to open local file .git/objects/pack/pack-c47999034002469dddee39ba0069c1b1a84487a5.idx for pack index
Getting alternates list for http://digilander.libero.it/mcostalba/scm/qgit.git/
Also look at <meta http-equiv="Refresh" content="5;URL=http://digiland.libe
Also look at <BASE HREF="http://digiland.liber
Segmentation fault (core dumped)


gdb backtrace is:

#0  0xb7caa5d0 in strncpy () from /lib/tls/libc.so.6
#1  0x0804c177 in process_alternates_response (callback_data=0xbfd428ec) at http-fetch.c:587
#2  0x0804a6c8 in process_curl_messages () at http.c:461
#3  0x0804a773 in step_active_slots () at http.c:379
#4  0x0804a7c7 in run_active_slot (slot=0x807f6a8) at http.c:400
#5  0x0804c565 in fetch_alternates (base=0xbfd45424 "http://digilander.libero.it/mcostalba/scm/qgit.git/") at http-fetch.c:668
#6  0x0804d46c in fetch (sha1=0x807f448 "÷ÜC\005\234¤-ì.§!J3Ñÿ<5ଥ\225¹\005\b") at http-fetch.c:1131
#7  0x0804a1ad in pull (target=0xbfd453fb "79ac640b3129344d4e94573ddaea09ccda1b8e3b") at fetch.c:168
#8  0x0804b590 in main (argc=5, argv=0xbfd43af4) at http-fetch.c:1269


The crash in process_alternates_response occurs on line:

587                                     strncpy(target + serverlen, data + i,
588                                             posn - i - 7);

(gdb) p target
$1 = 0x80800b8 "http://digilander.libero.it//-->\n</script>\n\n<script language=\"Javascript\" src=\"/x/js/nu05.js\"></script>\n\n<script>\n<!--\n\nfunction loaded() {\n\tcommon_boot();\n\t\n\t\t\n}\n\nfunction unloaded() {\n\tcommon_unload"...
(gdb) p target+serverlen
$2 = 0x80800d3 "//-->\n</script>\n\n<script language=\"Javascript\" src=\"/x/js/nu05.js\"></script>\n\n<script>\n<!--\n\nfunction loaded() {\n\tcommon_boot();\n\t\n\t\t\n}\n\nfunction unloaded() {\n\tcommon_unload();\n\t}\n\nfunction eoc() {\n\tc"...
(gdb) p data
$3 = 0x809c840 ""
(gdb) p i
$4 = 134739640
(gdb) p posn
$5 = 1304


Looks like something is going very wrong, like wrong assumptions about received HTML.

-- 
Yann Dirson    <ydirson@altern.org> |
Debian-related: <dirson@debian.org> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>