From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@suse.de>
Subject: Re: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
Date: Mon, 22 May 2006 13:01:30 +0200
Message-ID: <200605221301.30662.ak@suse.de>
References: <20060501215648.GU16776@us.ibm.com>
	<403a4dbd4c7329e3de93e78054d5ffaf@cl.cam.ac.uk>
	<20060519210857.GR16876@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20060519210857.GR16876@us.ibm.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, Ryan Grimm <grimm@us.ibm.com>
List-Id: xen-devel@lists.xenproject.org


> The patch is function on 32-bit and 64-bit boxes and parse the SRAT
> table and fills out the node_data array.  I installed a simple
> keyhandler 'u' to dump the info to check that it was function after
> booting up.

It mostly looks reasonable. As Keir noted you seem to have a lot of unnecessary
changes (printk->DPRINTK, white space etc.)

I would also suggest you keep the numa emulation. It's useful for debugging
so that developers without numa machines can reproduce numa issues.

-Andi