From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, linux-mm@kvack.org
Subject: Re: Extract have_task_perm() from kill and migrate functions.
Date: Mon, 22 May 2006 16:36:02 +0200 [thread overview]
Message-ID: <200605221636.02407.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0605220719310.3432@schroedinger.engr.sgi.com>
Why is this on linux-mm? Wouldn't it more for linux-kernel?
> ptrace() has a variation on the have_task_perm() check in may_attach().
> ptrace checks for uid equal to euid, suid, uid or gid equal to
> egid sgid,gid. So one may not be able to kill a process explicyly
> but be able to ptrace() (and then PTRACE_KILL it) if one is a member
> of the same group? Weird.
Sounds like a bug yes. I would suggest to switch it to the stricter
test from kill()
>
> Plus ptrace does not support eid comparision. So explicit rights
> for ptracing cannot be set via the super user bit.
That might even have a deeper meaning. I remember there were
subtle bugs in this area long ago. But likely it is a bug too.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-05-22 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 14:21 Extract have_task_perm() from kill and migrate functions Christoph Lameter
2006-05-22 14:36 ` Andi Kleen [this message]
2006-05-22 15:03 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605221636.02407.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.