All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: linux-kernel@vger.kernel.org, ak@suse.de,
	oprofile-list@lists.sourceforge.net
Subject: Re: [patch 5/8] Add SMP support on i386 to reservation framework
Date: Mon, 22 May 2006 13:55:27 -0400	[thread overview]
Message-ID: <20060522175527.GD15669@redhat.com> (raw)
In-Reply-To: <87mzdage4i.fsf@pike.pond.sub.org>

On Mon, May 22, 2006 at 07:31:41PM +0200, Markus Armbruster wrote:
> @@ -457,143 +434,312 @@ late_initcall(init_lapic_nmi_sysfs);
> [...]
>  static int setup_p6_watchdog(void)
> [...]
>  	apic_write(APIC_LVTPC, APIC_DM_NMI);
> -	evntsel |= P6_EVNTSEL0_ENABLE;
> -	wrmsr(MSR_P6_EVNTSEL0, evntsel, 0);
> +	evntsel |= K7_EVNTSEL_ENABLE;
> 
> Me thinks you want P6_EVNTSEL0_ENABLE here, although the value is the
> same.

Yup, the downside of copying/pasting...

Thanks.



  reply	other threads:[~2006-05-22 17:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-09 20:50 [patch 0/8] [RFC PATCH] nmi watchdog: x86 32/64 cleanup dzickus
2006-05-09 20:50 ` [patch 1/8] nmi watchdog header cleanup dzickus
2006-05-09 20:50 ` [patch 2/8] Add performance counter reservation framework for UP kernels dzickus
2006-05-09 20:50 ` [patch 3/8] Utilize performance counter reservation framework in oprofile dzickus
2006-05-09 20:50 ` [patch 4/8] Add SMP support on x86_64 to reservation framework dzickus
2006-05-09 21:42   ` Andi Kleen
2006-05-09 20:50 ` [patch 5/8] Add SMP support on i386 " dzickus
2006-05-22 17:31   ` Markus Armbruster
2006-05-22 17:55     ` Don Zickus [this message]
2006-05-09 20:50 ` [patch 6/8] Cleanup NMI interrupt path dzickus
2006-05-09 20:50 ` [patch 7/8] Remove un/set_nmi_callback and reserve/release_lapic_nmi functions dzickus
2006-05-09 20:50 ` [patch 8/8] Add abilty to enable/disable nmi watchdog from sysfs dzickus
2006-05-09 21:37   ` Andi Kleen
2006-05-10  9:10   ` Stephane Eranian
2006-05-10  9:28     ` Andi Kleen
2006-05-10 14:59     ` Don Zickus
2006-05-10 15:03       ` Stephane Eranian
2006-05-10 19:06         ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060522175527.GD15669@redhat.com \
    --to=dzickus@redhat.com \
    --cc=ak@suse.de \
    --cc=armbru@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.