From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [PATCH] 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures. Date: Tue, 23 May 2006 14:49:04 -0500 Message-ID: <20060523194904.GS16876@us.ibm.com> References: <200605231432.05451.pl@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200605231432.05451.pl@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paul Larson Cc: xen-devel List-Id: xen-devel@lists.xenproject.org * Paul Larson [2006-05-23 14:33]: > If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not get > restored causing subsequent boots to come up with only a single vcpu on dom0. Though I've never seen this mentioned on the list, I thought we wanted to leave the system in the failed state if a test failed? That's certainly debatable. Thoughts? > - num_online = int(getDomInfo("Domain-0", "VCPUs")) > - if num_online == dom0_online_vcpus: > - break > - time.sleep(1) > + num_online = int(getDomInfo("Domain-0", "VCPUs")) > + if num_online == dom0_online_vcpus: > + break > + time.sleep(1) White-space damage. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com