Re: [PATCH] TCP Veno module for kernel 2.6.16.13

[Stephen Hemminger <shemminger@osdl.org>]

On Wed, 24 May 2006 17:16:52 +0100
Baruch Even <baruch@ev-en.org> wrote:

> #ZHOU BIN# wrote:
> > From: Bin Zhou <zhou0022@ntu.edu.sg>
> > +		else if (sysctl_tcp_abc) {
> > + 			/* RFC3465: Apppriate Byte Count
> > + 	 		* increase once for each full cwnd acked.
> > + 	 		* Veno has no idear about it so far, so we keep
> > + 	 		* it as Reno.
> > + 	 		*/
> > + 			if (tp->bytes_acked >= tp->snd_cwnd*tp->mss_cache) {
> > + 				tp->bytes_acked -= tp->snd_cwnd*tp->mss_cache;
> > + 				if (tp->snd_cwnd < tp->snd_cwnd_clamp)
> > + 					tp->snd_cwnd++;
> > + 			}
> 
> You should prefer to ignore abc instead. At least that's what everyone
> else is doing, the only place where abc is active is in NewReno.
> 
> Baruch

That was intentional. When ABC was added, the desire was to not change existing
behavior for other congestion control methods.