All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Subject: Re: Slow fetches of tags
Date: Fri, 26 May 2006 16:42:39 +0100	[thread overview]
Message-ID: <20060526154239.GA20839@linux-mips.org> (raw)
In-Reply-To: <7vd5e21zh9.fsf@assigned-by-dhcp.cox.net>

On Wed, May 24, 2006 at 09:48:34PM -0700, Junio C Hamano wrote:

> I think the right fix for this is to change upload-pack to
> traverse reachability chain from the "want" heads as it gets
> "have" from the downloader, and stop responding "continue" when
> all "want" heads can reach some "have" commits.  This would not
> prevent it from going down all the way to the root commit if
> what is wanted does not have anything to do with what the other
> end has (e.g. if you have only my main project branches, and you
> ask for html head for the first time), but it would have
> prevented Ralf's tree from getting "continue" after he asked
> only for v2.6.16.18 tag and said he has 2.6.16.18 commit and its
> ancestors.  It should not be too difficult to do this, but here
> is an alternative, client-side workaround.
> 
> -- >8 --
> [PATCH] fetch-pack: give up after getting too many "ack continue"

So I did test your patch.  In the big, slow repository it cuts down the
time for a

  git fetch git://www.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git master:v2.6.16-stable

from like 6min to about 7s.

Thanks!

  Ralf

  reply	other threads:[~2006-05-26 15:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-24 13:10 Slow fetches of tags Ralf Baechle
2006-05-24 16:45 ` Linus Torvalds
2006-05-24 17:21   ` Linus Torvalds
2006-05-24 18:08     ` Junio C Hamano
2006-05-24 19:17       ` Linus Torvalds
2006-05-24 23:43         ` Linus Torvalds
2006-05-25  1:32           ` Junio C Hamano
2006-05-25  4:48             ` Junio C Hamano
2006-05-26 15:42               ` Ralf Baechle [this message]
2006-05-27  2:20                 ` [PATCH/RFC] upload-pack: stop "ack continue" when we know common commits for wanted refs Junio C Hamano
2006-05-25 13:12           ` Slow fetches of tags Ralf Baechle
2006-07-26 23:27             ` Junio C Hamano
2006-07-28 10:42               ` Johannes Schindelin
2006-07-28 11:12               ` [PATCH] Teach the git wrapper about --name-rev and --name-rev-by-tags Johannes Schindelin
2006-07-28 15:43                 ` Junio C Hamano
2006-07-28 16:59                 ` Linus Torvalds
2006-07-28 18:53                   ` Johannes Schindelin
2006-07-29 12:43                     ` Nguyễn Thái Ngọc Duy
2006-07-29 12:47                       ` Johannes Schindelin
2006-05-24 19:06     ` Slow fetches of tags Junio C Hamano
2006-05-24 18:08   ` Ralf Baechle
2006-05-24 18:41     ` Junio C Hamano
2006-05-25 13:27       ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060526154239.GA20839@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.