All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: "Garzik, Jeff" <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, "Brandeburg,
	Jesse" <jesse.brandeburg@intel.com>,
	"Kok, Auke" <auke-jan.h.kok@intel.com>,
	"Kok, Auke" <auke@foo-projects.org>
Subject: [PATCH 5/9] ixgb: remove lock access in the fast path
Date: Fri, 26 May 2006 09:52:05 -0700	[thread overview]
Message-ID: <20060526165204.30514.19446.stgit@gitlost.site> (raw)
In-Reply-To: <20060526165124.30514.78477.stgit@gitlost.site>


This mimics a change made in the e1000 driver that imitates a slick
tg3 way of avoiding grabbing the lock around restarting the tx queue.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: John Ronciak <john.ronciak@intel.com>
---

 drivers/net/ixgb/ixgb_main.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
index b825850..a714c4d 100644
--- a/drivers/net/ixgb/ixgb_main.c
+++ b/drivers/net/ixgb/ixgb_main.c
@@ -1800,13 +1800,13 @@ ixgb_clean_tx_irq(struct ixgb_adapter *a
 
 	tx_ring->next_to_clean = i;
 
-	spin_lock(&adapter->tx_lock);
-	if(cleaned && netif_queue_stopped(netdev) && netif_carrier_ok(netdev) &&
-	   (IXGB_DESC_UNUSED(tx_ring) > IXGB_TX_QUEUE_WAKE)) {
-
-		netif_wake_queue(netdev);
+	if (unlikely(netif_queue_stopped(netdev))) {
+		spin_lock(&adapter->tx_lock);
+		if (netif_queue_stopped(netdev) && netif_carrier_ok(netdev) &&
+		    (IXGB_DESC_UNUSED(tx_ring) > IXGB_TX_QUEUE_WAKE))
+			netif_wake_queue(netdev);
+		spin_unlock(&adapter->tx_lock);
 	}
-	spin_unlock(&adapter->tx_lock);
 
 	if(adapter->detect_tx_hung) {
 		/* detect a transmit hang in hardware, this serializes the



--
Auke Kok <auke-jan.h.kok@intel.com>

  parent reply	other threads:[~2006-05-26 16:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26 16:51 [PATCH 0/9] ixgb: driver update to 1.0.109-k2 Kok, Auke
2006-05-26 16:51 ` [PATCH 1/9] ixgb: fix smp polling race condition Kok, Auke
2006-05-26 16:51 ` [PATCH 2/9] ixgb: fix interface losing macaddr on ifdn/up Kok, Auke
2006-05-26 16:52 ` [PATCH 3/9] ixgb: revert an unwanted fix regarding tso/descriptors Kok, Auke
2006-05-26 16:52 ` [PATCH 4/9] ixgb: allocate only buffersize needed Kok, Auke
2006-05-26 16:52 ` Kok, Auke [this message]
2006-05-26 16:52 ` [PATCH 6/9] ixgb: remove inlines, allow compiler to choose Kok, Auke
2006-05-26 16:52 ` [PATCH 7/9] ixgb: replace netdev->priv with netdev_priv() Kok, Auke
2006-05-26 16:52 ` [PATCH 8/9] ixgb: remove changelog Kok, Auke
2006-05-26 16:52 ` [PATCH 9/9] ixgb: update version, dates Kok, Auke
2006-05-27  1:23 ` [PATCH 0/9] ixgb: driver update to 1.0.109-k2 Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060526165204.30514.19446.stgit@gitlost.site \
    --to=auke-jan.h.kok@intel.com \
    --cc=auke@foo-projects.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.