From: Olaf Hering <olh@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: add dmesg command to xmon
Date: Sun, 28 May 2006 14:07:48 +0200 [thread overview]
Message-ID: <20060528120748.GA7608@suse.de> (raw)
In-Reply-To: <200605281404.26070.arnd@arndb.de>
On Sun, May 28, Arnd Bergmann wrote:
> This whole function looks fishy to me. It seems unnecessarily rude to me to
> use kallsyms_lookup_name in order to get at a static variable from another
> file. Can't you instead add a global function to kernel/printk.c to return
> the buffer?
Its possible, but it wont end up in Linus tree.
> Also, what's the purpose of the sync/__delay code in here? If you use that
> to check for a possible machine check that may have happened, why not in
> the case where the lookup fails?
I just copied the other usages. Accessing the dmesg buffer itself may
need similar checks.
next prev parent reply other threads:[~2006-05-28 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-28 10:46 [PATCH] powerpc: add dmesg command to xmon Olaf Hering
2006-05-28 12:04 ` Arnd Bergmann
2006-05-28 12:07 ` Olaf Hering [this message]
2006-05-28 16:12 ` Arnd Bergmann
2006-05-29 17:58 ` Olaf Hering
2006-05-30 16:58 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060528120748.GA7608@suse.de \
--to=olh@suse.de \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.