From: Matthew Wilcox <matthew@wil.cx>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Greg KH <gregkh@suse.de>, Jeff Garzik <jgarzik@pobox.com>,
Greg KH <greg@kroah.com>, Jiri Slaby <jirislaby@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: searching for pci busses
Date: Tue, 30 May 2006 11:00:51 -0600 [thread overview]
Message-ID: <20060530170051.GA1610@parisc-linux.org> (raw)
In-Reply-To: <9e4733910605300952v1cf56beasc2a907cc77b8a09f@mail.gmail.com>
On Tue, May 30, 2006 at 12:52:31PM -0400, Jon Smirl wrote:
> This is how DRM does it...
> for (i = 0; driver->pci_driver.id_table[i].vendor != 0; i++) {
> pid = (struct pci_device_id *)&driver->pci_driver.id_table[i];
Why do you cast away the const warning? Why not just make pid a pointer
to const? drm_get_dev already has the const qualifier, so somebody
realised what the right thing to do was.
But looking at this code just reinforces the basic problem -- that DRM
does everything wrong and it needs shooting in the head.
next prev parent reply other threads:[~2006-05-30 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 23:13 searching for pci busses Jiri Slaby
2006-05-29 21:47 ` Greg KH
2006-05-29 21:59 ` Jeff Garzik
2006-05-30 16:38 ` Greg KH
2006-05-30 16:52 ` Jon Smirl
2006-05-30 16:58 ` Greg KH
2006-05-30 17:00 ` Matthew Wilcox [this message]
2006-05-30 17:19 ` Jon Smirl
2006-05-30 17:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060530170051.GA1610@parisc-linux.org \
--to=matthew@wil.cx \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=jirislaby@gmail.com \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.