All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodolfo Giometti <giometti@linux.it>
To: linux-mips@linux-mips.org
Subject: [PATCH] au1100fb fb_blank
Date: Wed, 31 May 2006 14:47:49 +0200	[thread overview]
Message-ID: <20060531124749.GE27426@enneenne.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

Hello,

since some boards need to manage GPIOs to turn on and off the LCD and
since on shutdwon the driver does:

   #if !defined(CONFIG_FRAMEBUFFER_CONSOLE) && defined(CONFIG_LOGO)
           au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
   #endif
           fbdev->regs->lcd_control &= ~LCD_CONTROL_GO;

I suggest the attached patch to do the same during boot.

Note that this prevents boards support developers to add
specific code before the command:

   fbdev->regs->lcd_control |= LCD_CONTROL_GO;

but putting all these stuff into proper function au1100fb_fb_blank().

Please, let me know what do you think about it.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127

[-- Attachment #2: patch-au1100fb-fb_blank --]
[-- Type: text/plain, Size: 709 bytes --]

diff --git a/drivers/video/au1100fb.c b/drivers/video/au1100fb.c
index 7c5fd9c..a59654b 100644
--- a/drivers/video/au1100fb.c
+++ b/drivers/video/au1100fb.c
@@ -110,6 +114,8 @@ static struct fb_var_screeninfo au1100fb
 
 static struct au1100fb_drv_info drv_info;
 
+int au1100fb_fb_blank(int blank_mode, struct fb_info *fbi);
+
 /*
  * Set hardware with var settings. This will enable the controller with a specific
  * mode, normally validated with the fb_check_var method
@@ -205,7 +211,7 @@ int au1100fb_setmode(struct au1100fb_dev
 	fbdev->regs->lcd_pwmhi = 0;
 
 	/* Resume controller */
-	fbdev->regs->lcd_control |= LCD_CONTROL_GO;
+	au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
 
 	return 0;
 }

                 reply	other threads:[~2006-05-31 12:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060531124749.GE27426@enneenne.com \
    --to=giometti@linux.it \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.