All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajesh Shah <rajesh.shah@intel.com>
To: "bibo,mao" <bibo.mao@intel.com>
Cc: akpm@osdl.org, Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	kaneshige.kenji@jp.fujitsu.com
Subject: Re: [BUG](-mm)pci_disable_device function clear bars_enabled element
Date: Thu, 1 Jun 2006 02:46:11 -0700	[thread overview]
Message-ID: <20060601024611.A32490@unix-os.sc.intel.com> (raw)
In-Reply-To: <447E91CE.7010705@intel.com>; from bibo.mao@intel.com on Thu, Jun 01, 2006 at 03:05:50PM +0800

On Thu, Jun 01, 2006 at 03:05:50PM +0800, bibo,mao wrote:
> I found that in -mm tree, function pci_disable_device() 
> clears bars_enabled variable, so that pci_release_regions 
> can not release reserved PCI I/O and memory resource. Some
> device driver programs in kernel tree call pci_release_regions
> function after pci_disable_device(), that will cause some problem.

It's coming from Kaneshige-san's patch:
pci-legacy-i-o-port-free-driver-changes-to-generic-pci-code.patch

This patch assumes that pci_request_region() will always be called
after pci_enable_device() and pci_release_region() will always
be called before pci_disable_device(). We cannot make this
assumption,since it's perfectly legal to disable a device
first and then release it's regions. So, I think that patch
needs to change.

thanks,
Rajesh

  reply	other threads:[~2006-06-01  9:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-01  7:05 [BUG](-mm)pci_disable_device function clear bars_enabled element bibo,mao
2006-06-01  9:46 ` Rajesh Shah [this message]
2006-06-01 17:15   ` Grant Grundler
2006-06-01 18:36     ` Rajesh Shah
2006-06-02  2:57       ` Kenji Kaneshige
2006-06-02  5:56         ` Grant Grundler
2006-06-02  7:31           ` Kenji Kaneshige
2006-06-03 23:21             ` Grant Grundler
2006-06-04 21:01               ` Greg KH
2006-06-05 12:40         ` [BUG][PATCH 2.6.17-rc5-mm3] bugfix: PCI legacy I/O port free driver Kenji Kaneshige
2006-06-06  7:58           ` Greg KH
2006-06-06  8:17             ` Kenji Kaneshige
2006-06-07  3:10             ` Kenji Kaneshige
2006-06-07  3:12               ` [PATCH 1/4] Changes to generic pci code Kenji Kaneshige
2006-06-07  3:13               ` [PATCH 2/4] Update Documentation/pci.txt Kenji Kaneshige
2006-06-07  3:14               ` [PATCH 3/4] Make Intel e1000 driver legacy I/O port free Kenji Kaneshige
2006-06-07  5:10                 ` Auke Kok
2006-06-07  7:39                   ` Kenji Kaneshige
2006-06-07 14:40                     ` Auke Kok
2006-06-08 12:31                 ` Jeff Garzik
2006-06-08 13:35                   ` Kenji Kaneshige
2006-06-08 14:46                     ` Jeff Garzik
2006-06-08 17:00                       ` Kenji Kaneshige
2006-06-07  3:15               ` [PATCH 4/4] Make Emulex lpfc " Kenji Kaneshige
2006-06-07  8:24                 ` Christoph Hellwig
2006-06-07 12:23                   ` Kenji Kaneshige
2006-06-07 12:43                     ` Christoph Hellwig
2006-06-07 13:11                       ` Kenji Kaneshige
2006-06-07 13:40                         ` Christoph Hellwig
2006-06-07 13:56                           ` Kenji Kaneshige
2006-06-07 14:52                             ` Christoph Hellwig
2006-06-07 17:26                               ` Rajesh Shah
2006-06-02  4:42       ` [BUG](-mm)pci_disable_device function clear bars_enabled element Grant Grundler
2006-06-02 16:50         ` Rajesh Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060601024611.A32490@unix-os.sc.intel.com \
    --to=rajesh.shah@intel.com \
    --cc=akpm@osdl.org \
    --cc=bibo.mao@intel.com \
    --cc=greg@kroah.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.