From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1FlpGa-0008WI-O4 for mharc-grub-devel@gnu.org; Thu, 01 Jun 2006 11:39:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FlpGY-0008Vj-QN for grub-devel@gnu.org; Thu, 01 Jun 2006 11:39:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FlpGW-0008V0-Vh for grub-devel@gnu.org; Thu, 01 Jun 2006 11:39:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FlpGW-0008Uw-SY for grub-devel@gnu.org; Thu, 01 Jun 2006 11:39:16 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FlpMn-0001eO-Jv for grub-devel@gnu.org; Thu, 01 Jun 2006 11:45:45 -0400 Received: from kotoba.oasis.nexedi.com (kotoba.oasis.nexedi.com [212.85.152.101]) by kotoba.storever.com (Postfix) with ESMTP id 2BF2A3CAD2ECE for ; Thu, 1 Jun 2006 19:14:17 +0200 (CEST) Received: from [??1] (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 6DBAA3CAD2ECD for ; Thu, 1 Jun 2006 19:14:16 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 1 Jun 2006 17:39:13 +0200 User-Agent: KMail/1.8.2 References: <447CB449.9080901@nic.fi> <200605310231.49399.okuji@enbug.org> <87bqtdykn0.wl%jeroen@vrijschrift.org> In-Reply-To: <87bqtdykn0.wl%jeroen@vrijschrift.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606011739.13486.okuji@enbug.org> X-Bogosity: No, tests=bogofilter, spamicity=0.348657, version=0.17.2 Subject: Re: [PATCH] Fix for configure on x86_64 (Was: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:39:19 -0000 On Wednesday 31 May 2006 23:00, Jeroen Dekkers wrote: > It's actually a necessary feature for GRUB on amd64. On amd64 you have > 64-bit executables but GRUB will run in 32-bit mode. > > When trying to compile on amd64 I already ran into some problems > related to that. First of all on amd64 all binaries are run in 64-bit > mode, so the host CFLAGS variable shouldn't have -m32. Secondly LIBS > is for the host only and shouldn't be defined when running target > tests. As last we set CFLAGS, CC, etc. to the TARGET_*, then we run > some checks and change the TARGET_* flags without updating CC, CFLAGS, > etc to the new version. > > The attached patch should fix those problems. I've tested it on i386-pc > and x86_64. It looks good. Please check it in. Thanks, Okuji