All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] hwmon w83792d add data lock to all store
Date: Thu, 01 Jun 2006 19:45:11 +0000	[thread overview]
Message-ID: <20060601214511.3b454f57.khali@linux-fr.org> (raw)
In-Reply-To: <447D3714.6070506@winbond.com.tw>

Hi Yuan,

> > > I add the lock to all store functions in this patch, please can
> > > you check?
> > 
> > It's OK except in store_pwmenable where you would leave with the lock
> > held on incorrect input value.
> > 
> > Your patch also lacked your signed-off-by line, and a proper summary...
> 
> Sorry, maybe i heat my head too heavily last time :(
> Can you check this one, thanks :)

No problem. I applied it with just one fix:

>  	default:
> -		return -EINVAL;
> +		break;
>  	}

This made the default case pretty useless so I dropped it altogether.

Thanks,
-- 
Jean Delvare


      parent reply	other threads:[~2006-06-01 19:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31  6:26 [lm-sensors] [PATCH] hwmon w83792d add data lock to all store Yuan Mu
2006-05-31 13:10 ` Jean Delvare
2006-06-01  3:25 ` Yuan Mu
2006-06-01 19:45 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060601214511.3b454f57.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.