From: Thomas Koeller <thomas.koeller@baslerweb.com>
To: linux-mips@linux-mips.org
Subject: Location of PCI setup code
Date: Thu, 1 Jun 2006 22:46:17 +0200 [thread overview]
Message-ID: <200606012246.17864.thomas.koeller@baslerweb.com> (raw)
Hi,
the PCI setup code for a platform is conventionally located in arch/mips/pci.
I fail to see the benefits of separating this particular part of a platform's
setup from the rest. The PCI setup code will in general contain references to
platform-specific information, such as the overall address space layout, of
which the PCI memory and I/O pages are a part. If the PCI setup code were in
the platform subdirectory, sharing this information by means of a
platform-local header file would be easy. But with the PCI code in
arch/mips/pci, this becomes more difficult. The platform header could be
located somewhere outside the platform's directory, maybe under
'include' (where?), or referenced via an ugly relative path like
'../../vendor/platform/platform.h'. All this seems rather clumsy to me. No
other part of a platform's initialization is separated from the rest in a
similar way, so what is so special about PCI setup that it cannot be in the
platform directory, thereby avoiding all these annoyances?
tk
--
Thomas Koeller, Software Development
Basler Vision Technologies
An der Strusbek 60-62
22926 Ahrensburg
Germany
Tel +49 (4102) 463-390
Fax +49 (4102) 463-46390
mailto:thomas.koeller@baslerweb.com
http://www.baslerweb.com
next reply other threads:[~2006-06-01 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 20:46 Thomas Koeller [this message]
2006-06-01 23:44 ` Location of PCI setup code Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2006-06-02 9:16 Koeller, T.
2006-06-02 9:16 ` Koeller, T.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606012246.17864.thomas.koeller@baslerweb.com \
--to=thomas.koeller@baslerweb.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.