All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Marzinski <bmarzins@redhat.com>
To: dm-devel@redhat.com
Subject: [multipath-tools] [patch] getopt cleanup
Date: Thu, 1 Jun 2006 19:19:12 -0500	[thread overview]
Message-ID: <20060602001912.GD25695@ether.msp.redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 72 bytes --]

'q' and 'i' are never used, so don't accept them as valid options

-Ben

[-- Attachment #2: getopt_cleanup.patch --]
[-- Type: text/plain, Size: 532 bytes --]

diff -urpN mp-devel-clean/multipath/main.c mp-devel-patched/multipath/main.c
--- mp-devel-clean/multipath/main.c	2006-04-03 14:10:39.000000000 -0500
+++ mp-devel-patched/multipath/main.c	2006-06-01 12:49:54.000000000 -0500
@@ -321,7 +321,7 @@ main (int argc, char *argv[])
 	if (load_config(DEFAULT_CONFIGFILE))
 		exit(1);
 
-	while ((arg = getopt(argc, argv, ":qdl::Ffi:M:v:p:b:")) != EOF ) {
+	while ((arg = getopt(argc, argv, ":dl::FfM:v:p:b:")) != EOF ) {
 		switch(arg) {
 		case 1: printf("optarg : %s\n",optarg);
 			break;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-06-02  0:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-02  0:19 Benjamin Marzinski [this message]
2006-06-10  6:40 ` [multipath-tools] [patch] getopt cleanup Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060602001912.GD25695@ether.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.