From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen Date: Fri, 2 Jun 2006 10:55:29 -0500 Message-ID: <20060602155529.GO1694@us.ibm.com> References: <20060501215648.GU16776@us.ibm.com> <403a4dbd4c7329e3de93e78054d5ffaf@cl.cam.ac.uk> <20060519210857.GR16876@us.ibm.com> <200605221301.30662.ak@suse.de> <20060524190222.GC1694@us.ibm.com> <20060531180629.GH1694@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060531180629.GH1694@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ryan Grimm , Andi Kleen List-Id: xen-devel@lists.xenproject.org * Ryan Harper [2006-05-31 13:06]: > * Ryan Harper [2006-05-24 14:02]: > > * Andi Kleen [2006-05-22 06:02]: > > > > > > > The patch is function on 32-bit and 64-bit boxes and parse the SRAT > > > > table and fills out the node_data array. I installed a simple > > > > keyhandler 'u' to dump the info to check that it was function after > > > > booting up. > > > > > > It mostly looks reasonable. As Keir noted you seem to have a lot of unnecessary > > > changes (printk->DPRINTK, white space etc.) > > > > Cleaned up. > > > > > > > > I would also suggest you keep the numa emulation. It's useful for debugging > > > so that developers without numa machines can reproduce numa issues. > > > > Added numa emulation back in. I've set it up such that if we fail to > > find a numa-node we fallback on to emulation of one node. This allows > > the allocator code to not be filled with CONFIG_NUMA ifdefs as Keir > > wanted. > > This last patch didn't have a functional cpu_to_node/node_to_cpumask. > This patch fixes that up in addition to the previous cleanups. Please > take a look. I wanted to follow up and see if anyone has had a chance to look at the latest rework (patch 1 and 2). Wasn't sure if this had fallen off your radar. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com