From: Olaf Hering <olh@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk
Subject: Re: [PATCH] cramfs corruption after BLKFLSBUF on loop device
Date: Fri, 2 Jun 2006 23:06:03 +0200 [thread overview]
Message-ID: <20060602210603.GA10395@suse.de> (raw)
In-Reply-To: <20060602124143.0898384f.akpm@osdl.org>
On Fri, Jun 02, Andrew Morton wrote:
> Oh, OK, we cannot use read_cache_page(). Because the above is still racy
> (and still needs the retry loop). We need to set PG_checked before
> launching the read. Something like:
>
> /*
> * Return a locked, uptodate, !PagePrivate, !PageChecked page which needs a
> * single put_page by the caller.
> */
> cramfs_read_getpage()
> {
> page = find_lock_page()
> if (PageUptodate(page))
> return page;
> SetPagePrivate()
> SetPageChecked()
> err = m->a_ops->readpage(page);
I guess we have to put a find_or_create_page in there, and fill it.
Will try that tomorrow.
next prev parent reply other threads:[~2006-06-02 21:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 21:40 cramfs corruption after BLKFLSBUF on loop device Olaf Hering
2006-05-30 13:19 ` Olaf Hering
2006-05-30 18:24 ` Olaf Hering
2006-06-01 18:49 ` [PATCH] " Olaf Hering
2006-06-01 19:12 ` Andrew Morton
2006-06-01 19:15 ` Andrew Morton
2006-06-01 20:10 ` Olaf Hering
2006-06-01 21:24 ` Andrew Morton
2006-06-01 21:41 ` Olaf Hering
2006-06-01 21:57 ` Andrew Morton
2006-06-02 8:43 ` Olaf Hering
2006-06-02 9:11 ` Andrew Morton
2006-06-02 19:14 ` Olaf Hering
2006-06-02 19:41 ` Andrew Morton
2006-06-02 21:06 ` Olaf Hering [this message]
2006-06-02 19:37 ` Olaf Hering
2006-06-02 19:46 ` Andrew Morton
2006-06-03 13:13 ` Olaf Hering
2006-06-01 20:17 ` Chris Mason
2006-06-01 20:20 ` Olaf Hering
2006-06-01 20:29 ` Chris Mason
2006-09-20 13:20 ` Olaf Hering
2006-09-20 18:47 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060602210603.GA10395@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.