Re: sata_mv with Adaptec AIC-8130/Marvell 88SX6041 ("Badness in __msleep")

[Mark Lord <liml@rtr.ca>]

On Friday 02 June 2006 21:42, Ask Bjørn Hansen wrote:
> 
> On May 28, 2006, at 19:49, Mark Lord wrote:
> 
> > The attached patch [0.7-backport] is an untested backport of the  
> > latest sata_mv,
> > which should be more reliable than what you've been using. [0.5]
> 
> It works most of the time (where the 0.5 didn't work most of the  
> time), but I still see the "Badness in __msleep" occasionally (and it  
> only detects one of the disks then).    However, the Adaptec BIOS is  
> only seeing one of the disks sometimes, so maybe there's something  
> wrong with the hardware.  The BIOS did detect both drives in the boot  
> that gave the output below though.

Weird.  I cannot make sense of that traceback.  What CPU is this kernel built for?

And does this patch (below) make the "Badness" go away?

Cheers

---
--- linux/drivers/scsi/sata_mv.c.16-backport	2006-05-26 09:15:22.000000000 -0400
+++ linux/drivers/scsi/sata_mv.c	2006-06-02 22:39:07.000000000 -0400
@@ -2022,7 +2022,7 @@
 
 static void mv_phy_reset(struct ata_port *ap)
 {
-	__mv_phy_reset(ap, 1);
+	__mv_phy_reset(ap, 0);
 }
 
 /**